[ci skip]

[ci skip]

[ci skip]

Trigger Elasticsearch indexing when public group moved to private

See merge request gitlab/gitlabhq!3578

This fixes https://gitlab.com/gitlab-org/gitlab/issues/37766 which is
caused by the fact that we leave the stale permissions data in the index
after a group is moved to another group.

[ci skip]

[ci skip]

Fix invalid byte sequence

See merge request gitlab/gitlabhq!3548

Update Workhorse and Gitaly to fix a security issue

See merge request gitlab/gitlabhq!3500

Use Gitlab::HTTP for all chat notifications

See merge request gitlab/gitlabhq!3516

Fix private comment Elasticsearch leak

See merge request gitlab/gitlabhq!3524

Hide AWS secret on Admin Integration page

See merge request gitlab/gitlabhq!3526

Prevent guests from seeing commits for cycle analytics

See merge request gitlab/gitlabhq!3533

Related Branches Visible to Guests in Issue Activity

See merge request gitlab/gitlabhq!3539

GitLab stores AWS, Slack, Askimet, reCaptcha tokens in plaintext

See merge request gitlab/gitlabhq!3542

Escape namespace in label references

See merge request gitlab/gitlabhq!3551

Check permissions before showing a forked project's source

See merge request gitlab/gitlabhq!3556

Ensure attributes that end in `_ids` are cleaned

See merge request gitlab/gitlabhq!3559

DJ Mountney authored 5 years ago and Imre (Admin) committed 5 years ago

This prevents an issue where you can steal other projects objects by
asking for ids that don't belong to you in import.

We had concerns about the cached values on Redis with the previous two
releases strategy:

First release (this commit):
  - Create new encrypted fields in the database.
  - Start populating new encrypted fields, read the encrypted fields or
    fallback to the plaintext fields.
  - Backfill the data removing the plaintext fields to the encrypted
    fields.
Second release:
  - Remove the virtual attribute (created in step 2).
  - Drop plaintext columns from the database (empty columns after
    step 3).

We end up with a better strategy only using migration scripts in one
release:
  - Pre-deployment migration: Add columns required for storing encrypted
    values.
  - Pre-deployment migration: Store the encrypted values in the new
    columns.
  - Post-deployment migration: Remove the old unencrypted columns

When referencing cross-namespace labels, we append the namespace name
to the rendered label.

This MR escapes the name to prevent XSS attacks.