Giorgenes Gelatti authored 5 years ago and Thong Kuah committed 5 years ago

Extends the permission of $CI_REGISTRY_USER to allow them
to delete tags in addition to just pushing.

https://gitlab.com/gitlab-org/gitlab-ce/issues/40096

Introducing Docker Registry replication

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

For directories application_settings --> labels.

Partially addresses #47424.

- Adds a default on expires_at datetime
- Modifies deploy tokens views to handle default expires at value
- Use datetime_with_timezone where possible
- Remove unused scopes

Also, fixes broken specs

Also:
- Changes scopes from serializer to use boolean columns
- Fixes broken specs

- When using 'read_repo' password and project are sent, so we used both
  of them to fetch for the token
- When using 'read_registry' only the password is sent, so we only use
  that for fetching the token

The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.

Also fix the test because we no longer have :empty_project,
just use :project is the same as before

Because we do not have yet two way communication between container
registry and GitLab, we need to eagerly create a new container
repository objects in database. We now do that after user/build
successfully authenticates a push action using auth service.

Comment explains why we still have authentication without user object
there. The legacy authentication mechanism should be removed in 10.0.

[ci skip]

Conflicts:
	db/schema.rb

  - Adds Registry events API endpoint
  - Adds container_images_repository and container_images models
  - Changes JWT authentication to allow multi-level scopes
  - Adds services for container image maintenance

add complete changelog for !8949

Restore unauthenticated access to public container registries

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24284



See merge request !2025

Signed-off-by: Rémy Coutable <remy@rymai.me>

Ensure external users are not able to clone disabled repositories.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23788



See merge request !2017

Signed-off-by: Rémy Coutable <remy@rymai.me>