Skip to content
Snippets Groups Projects
  1. Sep 04, 2019
  2. Aug 30, 2019
  3. Aug 29, 2019
  4. Aug 28, 2019
    • Sean McGivern's avatar
      Make performance bar enabled checks consistent · f9c456bd
      Sean McGivern authored
      Previously, we called the `peek_enabled?` method like so:
      
          prepend_before_action :set_peek_request_id, if: :peek_enabled?
      
      Now we don't have a `set_peek_request_id` method, so we don't need that
      line. However, the `peek_enabled?` part had a side-effect: it would also
      populate the request store cache for whether the performance bar was
      enabled for the current request or not.
      
      This commit makes that side-effect explicit, and replaces all uses of
      `peek_enabled?` with the more explicit
      `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that
      still sets `SafeRequestStore[:peek_enabled]` directly, because it is
      contrasting behaviour with and without a request store enabled.
      
      The upshot is:
      
      1. We still set the value in one place. We make it more explicit that
         that's what we're doing.
      2. Reading that value uses a consistent method so it's easier to find in
         future.
      f9c456bd
    • Igor Drozdov's avatar
      Change the way totalNotes is calculated · 72544449
      Igor Drozdov authored
      totalNotes is only used to prerender a number of
      skeleton containers until real notes are loaded
      
      issuable.discussions makes multiple requests, so
      too expensive for this
      
      This commit uses mere notes for this and sends
      actual totalNotes number if it's less than 10;
      otherwise it sends 10 - it allows us to avoid
      bunch of skeleton prerenderings, which are not
      necessary since they doesn't fit into the whole
      screen and disappear quite fast
      72544449
    • Arun Kumar Mohan's avatar
      Add Issue and Merge Request titles to Todo items · 4ca32c2b
      Arun Kumar Mohan authored
      Only displays the todo body if the todo has a note.
      This is to avoid redundant Issue or Merge Request titles
      displayed both in the Todo title and body.
      4ca32c2b
  5. Aug 24, 2019
  6. Aug 23, 2019
  7. Aug 22, 2019
    • Scott Hampton's avatar
      Update GitHub CI/CD import page to use PAT only · 56294b4e
      Scott Hampton authored and Mayra Cabrera's avatar Mayra Cabrera committed
      Oauth2 tokens are causing issues with mirroring
      repos, because it effectively limits the number
      of repos you can mirror. Personal Access
      Tokens do not have this problem.
      
      This change removes the OAuth2 option from
      the import page for CI/CD only, and only
      provides the personal access token form.
      56294b4e
  8. Aug 21, 2019
  9. Aug 19, 2019
  10. Aug 17, 2019
  11. Aug 15, 2019
  12. Aug 14, 2019
  13. Aug 12, 2019
  14. Aug 07, 2019
  15. Aug 05, 2019
  16. Aug 02, 2019
  17. Jul 31, 2019
    • mksionek's avatar
      Add captcha if there are multiple failed login attempts · dfcf4cf5
      mksionek authored
      Add method to store session ids by ip
      
      Add new specs for storing session ids
      
      Add cleaning up records after login
      
      Add retrieving anonymous sessions
      
      Add login recaptcha setting
      
      Add new setting to sessions controller
      
      Add conditions for showing captcha
      
      Add sessions controller specs
      
      Add admin settings specs for login protection
      
      Add new settings to api
      
      Add stub to devise spec
      
      Add new translation key
      
      Add cr remarks
      
      Rename class call
      
      Add cr remarks
      
      Change if-clause for consistency
      
      Add cr remarks
      
      Add code review remarks
      
      Refactor AnonymousSession class
      
      Add changelog entry
      
      Move AnonymousSession class to lib
      
      Move store unauthenticated sessions to sessions controller
      
      Move link to recaptcha info
      
      Regenerate text file
      
      Improve copy on the spam page
      
      Change action filter for storing anonymous sessions
      
      Fix rubocop offences
      
      Add code review remarks
      dfcf4cf5
  18. Jul 29, 2019
  19. Jul 26, 2019
  20. Jul 25, 2019
  21. Jul 24, 2019
  22. Jul 23, 2019
  23. Jul 22, 2019
  24. Jul 17, 2019
Loading