Skip to content
Snippets Groups Projects
  1. Oct 09, 2013
    • Johannes Becker's avatar
      14c5e24a
    • Marin Jankovski's avatar
      Test. · 7039fb66
      Marin Jankovski authored
      7039fb66
    • Hiroyuki Sato's avatar
      Drop support of root namespace in routing · b70ca8e3
      Hiroyuki Sato authored
      b70ca8e3
    • Ryan Mendivil's avatar
      Fix bug with rendering changing images in commits · ab478f2a
      Ryan Mendivil authored
      When viewing the diff for a changed image file, two bugs occur:
      
      - Both the 'before' and 'after' images link to the 'after' commit
      - Visiting the link for either image will cause a error
      
      The first is caused by both image links referencing '@commit.id' rather
      than '@commit.parent_id'.  The second is caused by the use of
      'project_tree_path' which is used for creating links to directories in
      the git file tree. 'project_blob_path' which links to files should be
      used instead.
      ab478f2a
    • Dmitriy Zaporozhets's avatar
      Fix feature test · 7b996818
      Dmitriy Zaporozhets authored
      7b996818
    • Boyan Tabakov's avatar
      Improved large commit handling. · 60036c86
      Boyan Tabakov authored
      Previously, only number of changed files mattered. Now, number of lines to render in the diff are also taken into account.
      
      A hard limit is set, above which diffs are not rendered and users are not allowed to override that. This prevents high server
      resource usage with huge commits.
      
      Related to #1745, #2259
      
      In addition, handle large commits for MergeRequests and Compare controllers.
      
      Also fixes a bug where diffs are loaded twice, if user goes directly to merge_requests/:id/diffs URL.
      60036c86
  2. Aug 27, 2013
  3. Aug 21, 2013
  4. Aug 12, 2013
  5. Aug 08, 2013
  6. Aug 02, 2013
  7. Aug 01, 2013
  8. Jul 18, 2013
    • Dmitriy Zaporozhets's avatar
      Fix tests · 98e1597f
      Dmitriy Zaporozhets authored
      98e1597f
    • Izaak Alpert's avatar
      Fix an issue with edits sending user back to @source_project · 0a013adc
      Izaak Alpert authored
      -Form was for @source_project rather then @Project.
      -add spinach test for edit submission on forked project
      
      Change-Id: I807a5077608b7e910f4bc83c5d3e82c378f70a9e
      0a013adc
    • Izaak Alpert's avatar
      Style changes from review with @randx · d9959427
      Izaak Alpert authored
      -Some changes around calling origional methods for !for_fork? merge requests. Other changes to follow
      
      Change-Id: I009c716ce2475b9efa3fd07aee9215fca7a1c150
      d9959427
    • Izaak Alpert's avatar
      Rebased on 6.0 · 128f2845
      Izaak Alpert authored
      -Had to do some minor test clean up as well
      
      Change-Id: I8f378f1b5fe676d73b8691e870c11ca6def90cbf
      128f2845
    • Izaak Alpert's avatar
      MR on fork: Email fixes, style fixes · 0ef055a4
      Izaak Alpert authored
      -Removed many extra spaces I added
      -Fixed email templates to be consistent/better looking
      
      GITLAB-894, GITLAB-895, (GITLAB-858)
      
      Change-Id: I35c1a8e0e22af7de26d54e5c3da987fa7bb3921e
      0ef055a4
    • Izaak Alpert's avatar
      Rebase on master · 09112dbb
      Izaak Alpert authored
      Trying to retrigger travis
      Change-Id: Ifd86fb4c6b2791ad176230254fbf69a9ade979fb
      09112dbb
    • Izaak Alpert's avatar
      MR on fork validation error · bbef8bb5
      Izaak Alpert authored
      Wasn't setting fields so validations would fail
      
      Change-Id: I0363c57bf6c8b9937cc1b4140d09071d7c5168c2
      bbef8bb5
    • Izaak Alpert's avatar
      MR on fork: Some cleanup, test updates · 5d56da6b
      Izaak Alpert authored
      -The forked merge request test now tests it's componenets again, and seems to work every time (did this by reordering the branch updates so their is more time for update_branches to run) -- this could still technically fail, but after several runs it doesn't seem to.
      -Removed todo in merge_request, pushed wrapping of grit down to the satellite
      -updated action test to check flock status, made it nolonger pending
      -moved all logging on failure to helper method in satellite
      GITLAB-592
      
      Change-Id: If0554ca35eedc3d3e8461f7d93d4b3939fa2cd75
      5d56da6b
    • Izaak Alpert's avatar
      MR on Fork multiple fixes · 489fa5d7
      Izaak Alpert authored
      -Disable observers post test run
      -Allow db:seed_fu RAILS_ENV=test to be run more than once without error
      -fix diffs_in_between, was passing in the default_options for grit, but grit in this case doesn't take options, fixed the test to actually fail if the incorrect diffs are returned
      -make notes/commits render against proper project
      -MR discussion file links should reference note's project
      -Added tests for commit links on edit merge request
      -fixes edit issues (canceling an edited mr, updating an edited mr)
      -updates tests with checks for source code updates
      -still forked_merge_requests.feature (project_forked_merge_requests) test not passing (commented out -- "stable" not being set)
      
      MR API: error on bad target_project
      
      -If the target project id is specified and it is not the same as the project the request is being made on (the source), and the it isn't a fork of that project, error out, otherwise use it as the target
      -Fixes some busted (but hidden) test cases
      
      Conflicts:
      	app/views/merge_requests/show/_diffs.html.haml
      	spec/features/notes_on_merge_requests_spec.rb
      
      Change-Id: I20e595c156d0e8a63048baaead7be6330c738a05
      489fa5d7
    • Izaak Alpert's avatar
      Merge Request on forked projects · 3d7194f0
      Izaak Alpert authored
      The good:
      
       - You can do a merge request for a forked commit and it will merge properly (i.e. it does work).
       - Push events take into account merge requests on forked projects
       - Tests around merge_actions now present, spinach, and other rspec tests
       - Satellites now clean themselves up rather then recreate
      
      The questionable:
      
       - Events only know about target projects
       - Project's merge requests only hold on to MR's where they are the target
       - All operations performed in the satellite
      
      The bad:
      
        -  Duplication between project's repositories and satellites (e.g. commits_between)
      
      (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos)
      
      Fixes:
      
      Make test repos/satellites only create when needed
      -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap)
      -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually
      -fixed remote removal
      -How to merge renders properly
      -Update emails to show project/branches
      -Edit MR doesn't set target branch
      -Fix some failures on editing/creating merge requests, added a test
      -Added back a test around merge request observer
      -Clean up project_transfer_spec, Remove duplicate enable/disable observers
      -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well
      -Signifant speed ups for tests
      -Update formatting ordering in notes_on_merge_requests
      -Remove wiki schema update
      Fixes for search/search results
      -Search results was using by_project for a list of projects, updated this to use in_projects
      -updated search results to reference the correct (target) project
      -udpated search results to print both sides of the merge request
      
      Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
      3d7194f0
  9. Jul 15, 2013
  10. Jul 13, 2013
  11. Jun 22, 2013
  12. Jun 19, 2013
  13. Jun 18, 2013
  14. Jun 17, 2013
  15. Jun 14, 2013
  16. Jun 12, 2013
  17. Jun 11, 2013
  18. Jun 06, 2013
Loading