- Jan 28, 2020
-
-
GitLab Bot authored
-
- Jan 21, 2020
-
-
GitLab Bot authored
-
- Dec 20, 2019
-
-
GitLab Bot authored
-
- Nov 19, 2019
-
-
GitLab Bot authored
-
- Oct 22, 2019
-
-
Kerri Miller authored
This method, #route_not_found, is executed as the final fallback for unrecognized routes (as the name might imply.) We want to avoid `#authenticate_user!` when calling `#route_not_found`; `#authenticate_user!` can, depending on the request format, return a 401 instead of redirecting to a login page. This opens a subtle security exploit where anonymous users will receive a 401 response when attempting to access a private repo, while a recognized user will receive a 404, exposing the existence of the private, hidden repo.
-
GitLab Bot authored
-
- Sep 13, 2019
-
-
GitLab Bot authored
-
- Aug 31, 2019
-
-
dineshpanda authored
-
- Aug 15, 2019
-
-
George Koltsov authored
-
- Aug 14, 2019
-
-
George Koltsov authored
-
- Aug 08, 2019
-
-
Alex Buijs authored
-
- Jul 25, 2019
-
-
Heinrich Lee Yu authored
These are not required because MySQL is not supported anymore
-
- Jul 23, 2019
-
-
Manoj M J authored
This change adds audit logs for user impersonation when an admin starts/stops impersonating another user.
-
- Jun 26, 2019
-
-
Stan Hu authored
As we noticed in https://gitlab.com/gitlab-org/gitlab-ce/issues/56627#note_185828742, clicking on the "Issues" tab often requests the same reference in rendering Markdown.
-
- Jun 05, 2019
-
-
James Edwards-Jones authored
-
- May 31, 2019
-
-
Bob Van Landuyt authored
This sets up all the basics for importing Phabricator tasks into GitLab issues. To import all tasks from a Phabricator instance into GitLab, we'll import all of them into a new project that will have its repository disabled. The import is hooked into a regular ProjectImport setup, but similar to the GitHub parallel importer takes care of all the imports itself. In this iteration, we're importing each page of tasks in a separate sidekiq job. The first thing we do when requesting a new page of tasks is schedule the next page to be imported. But to avoid deadlocks, we only allow a single job per worker type to run at the same time. For now we're only importing basic Issue information, this should be extended to richer information.
-
- May 02, 2019
-
-
James Edwards-Jones authored
- This can be accessed with Session.current and is restored after. - Data can be stored under a key with NamespacedSessionStore
-
- Apr 18, 2019
-
-
Andrew Newdigate authored
This change is a fairly straightforward refactor to extract the tracing and correlation-id code from the gitlab rails codebase into the new LabKit-Ruby project. The corresponding import into LabKit-Ruby was in https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1 The code itself remains very similar for now. Extracting it allows us to reuse it in other projects, such as Gitaly-Ruby. This will give us the advantages of correlation-ids and distributed tracing in that project too.
-
- Apr 08, 2019
-
-
Martin Wortschack authored
- Externalize strings in controllers - Update PO file
-
- Feb 26, 2019
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Feb 12, 2019
-
-
Stan Hu authored
`queue_duration` is a useful metric that is currently in api_json.log but not in production_json.log. We should add it because it tells us how long the request sat in Workhorse before Unicorn processed it. Having this field enables the support team to better troubleshoot when delays began to happen.
-
- Jan 15, 2019
-
-
Luke "Jared" Bennett authored
-
- Jan 02, 2019
-
-
Jasper Maes authored
-
- Dec 19, 2018
-
-
Jarka Kadlecova authored
- we now use the hierarchy class also for epics - also rename supports_nested_groups? into supports_nested_objects? - move it to a concern
-
- Dec 16, 2018
-
-
Jasper Maes authored
-
- Dec 06, 2018
-
-
Kamil Trzcińśki authored
The Correlation ID is taken or generated from received X-Request-ID. Then it is being passed to all executed services (sidekiq workers or gitaly calls). The Correlation ID is logged in all structured logs as `correlation_id`.
-
- Nov 29, 2018
-
-
Imre (Admin) authored
Adds gitlab.impersonation_enabled config option defaulting to true to keep the current default behaviour. Only the act of impersonation is modified, impersonation token management is not affected.
-
Cindy Pallares authored
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583
-
- Nov 23, 2018
-
-
James Lopez authored
-
- Nov 18, 2018
-
-
Imre (Admin) authored
-
- Nov 15, 2018
-
-
Jasper Maes authored
-
- Oct 23, 2018
-
-
James Lopez authored
-
- Oct 13, 2018
-
-
Jan Provaznik authored
In Rails 5 catches invalid UTF8 characters in querystring in a params middleware, errors are handled by a params middleware and raises a BadRequest exception. This means that these UTF8 errors are not raised deeper in application stack and these can't also be handled on application level. If we would want to have custom handler for these errors, we would have to create a new middleware and insert it before actionpack's params middleware and rescue BadRequest exceptions there. But there is no need to do this currently (see discussion on https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
-
- Oct 10, 2018
-
-
Zeger-Jan van de Weg authored
Was introduced in the time that GitLab still used NFS, which is not required anymore in most cases. By removing this, the API it calls will return empty responses. This interface has to be removed in the next major release, expected to be 12.0.
-
- Oct 08, 2018
-
-
Stan Hu authored
Raven.capture_exception is already called by log_exception.
-
- Oct 01, 2018
-
-
David authored
-
- Sep 26, 2018
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Igor Kapkov authored
-
- Sep 22, 2018
-
-
Felipe Artur authored
Renders 412 error page when invalid UTF-8 is passed as parameters in controllers.
-
- Sep 19, 2018
-
-
gfyoung authored
Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424.
-