Skip to content
Snippets Groups Projects
  1. Dec 08, 2015
  2. Dec 07, 2015
  3. Dec 06, 2015
  4. Dec 05, 2015
    • Anton Baklanov's avatar
      caa6851b
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      d800a949
  5. Dec 04, 2015
  6. Dec 03, 2015
  7. Dec 02, 2015
  8. Dec 01, 2015
  9. Nov 30, 2015
  10. Nov 26, 2015
  11. Nov 25, 2015
  12. Nov 24, 2015
  13. Nov 23, 2015
  14. Nov 21, 2015
  15. Nov 19, 2015
Loading