Skip to content
Snippets Groups Projects
  1. Jan 24, 2018
  2. Jan 22, 2018
  3. Jan 18, 2018
  4. Jan 16, 2018
  5. Jan 15, 2018
  6. Jan 12, 2018
  7. Jan 11, 2018
  8. Jan 10, 2018
  9. Jan 09, 2018
  10. Jan 05, 2018
  11. Dec 22, 2017
  12. Dec 20, 2017
  13. Dec 19, 2017
    • Zeger-Jan van de Weg's avatar
      Load commit in batches for pipelines#index · c6edae38
      Zeger-Jan van de Weg authored
      Uses `list_commits_by_oid` on the CommitService, to request the needed
      commits for pipelines. These commits are needed to display the user that
      created the commit and the commit title.
      
      This includes fixes for tests failing that depended on the commit
      being `nil`. However, now these are batch loaded, this doesn't happen
      anymore and the commits are an instance of BatchLoader.
      Unverified
      c6edae38
  14. Dec 14, 2017
  15. Dec 13, 2017
  16. Dec 12, 2017
  17. Dec 07, 2017
  18. Dec 06, 2017
  19. Dec 01, 2017
  20. Nov 23, 2017
  21. Nov 21, 2017
  22. Nov 17, 2017
    • Sean McGivern's avatar
      Fix conflict highlighting · 64a9e53b
      Sean McGivern authored
      Conflicts used to take a `Repository` and pass that to
      `Gitlab::Highlight.highlight`, which would call `#gitattribute` on the
      repository. Now they use a `Gitlab::Git::Repository`, which didn't have that
      method defined - but defining it on `Gitlab::Git::Repository` does make it
      available on `Repository` through `method_missing`, so we can do that and both
      cases will work.
      64a9e53b
  23. Nov 16, 2017
  24. Nov 10, 2017
  25. Nov 07, 2017
    • Yorick Peterse's avatar
      Rewrite the GitHub importer from scratch · 4dfe26cd
      Yorick Peterse authored
      Prior to this MR there were two GitHub related importers:
      
      * Github::Import: the main importer used for GitHub projects
      * Gitlab::GithubImport: importer that's somewhat confusingly used for
        importing Gitea projects (apparently they have a compatible API)
      
      This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
      introduces a new GitHub importer in the Gitlab::GithubImport namespace.
      This new GitHub importer uses Sidekiq for importing multiple resources
      in parallel, though it also has the ability to import data sequentially
      should this be necessary.
      
      The new code is spread across the following directories:
      
      * lib/gitlab/github_import: this directory contains most of the importer
        code such as the classes used for importing resources.
      * app/workers/gitlab/github_import: this directory contains the Sidekiq
        workers, most of which simply use the code from the directory above.
      * app/workers/concerns/gitlab/github_import: this directory provides a
        few modules that are included in every GitHub importer worker.
      
      == Stages
      
      The import work is divided into separate stages, with each stage
      importing a specific set of data. Stages will schedule the work that
      needs to be performed, followed by scheduling a job for the
      "AdvanceStageWorker" worker. This worker will periodically check if all
      work is completed and schedule the next stage if this is the case. If
      work is not yet completed this worker will reschedule itself.
      
      Using this approach we don't have to block threads by calling `sleep()`,
      as doing so for large projects could block the thread from doing any
      work for many hours.
      
      == Retrying Work
      
      Workers will reschedule themselves whenever necessary. For example,
      hitting the GitHub API's rate limit will result in jobs rescheduling
      themselves. These jobs are not processed until the rate limit has been
      reset.
      
      == User Lookups
      
      Part of the importing process involves looking up user details in the
      GitHub API so we can map them to GitLab users. The old importer used
      an in-memory cache, but this obviously doesn't work when the work is
      spread across different threads.
      
      The new importer uses a Redis cache and makes sure we only perform
      API/database calls if absolutely necessary.  Frequently used keys are
      refreshed, and lookup misses are also cached; removing the need for
      performing API/database calls if we know we don't have the data we're
      looking for.
      
      == Performance & Models
      
      The new importer in various places uses raw INSERT statements (as
      generated by `Gitlab::Database.bulk_insert`) instead of using Rails
      models. This allows us to bypass any validations and callbacks,
      drastically reducing the number of SQL queries and Gitaly RPC calls
      necessary to import projects.
      
      To ensure the code produces valid data the corresponding tests check if
      the produced rows are valid according to the model validation rules.
      Verified
      4dfe26cd
  26. Nov 06, 2017
  27. Nov 03, 2017
Loading