Skip to content
Snippets Groups Projects
  1. Sep 02, 2019
  2. Aug 09, 2019
  3. Aug 05, 2019
  4. May 27, 2019
    • Jacopo's avatar
      Removes duplicated members from api/projects/:id/members/all · a9827e0e
      Jacopo authored
      When using the members/all api the same user was returned multiple times
      when he was a member of the project/group and also of one of the
      ancestor groups.
      Now the member is returned only once giving priority to the membership
      on the project and maintaining the same behaviour of the members UI.
      a9827e0e
  5. Apr 30, 2019
    • Stan Hu's avatar
      Allow a member to have an access level equal to parent group · 32ddc3fe
      Stan Hu authored
      Suppose you have this configuration:
      
      1. Subgroup `hello/world`
      2. Subgroup `hello/mergers`.
      3. Project `hello/world/my-project` has invited group `hello/world` to
      access protected branches.
      4. The rule allows the group to merge but no one can push.
      5. User `newuser` has Owner access to the parent group `hello`.
      
      Previously, there was no way for the user `newuser` to be added to the
      `hello/mergers` group since the validation only allowed a user to be
      added at a higher access level.
      
      Since membership in a subgroup confers certain access rights, such as
      being able to merge or push code to protected branches, we have to
      loosen the validation and allow someone to be added at an equal level
      granted by the parent group.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11323
      32ddc3fe
  6. Mar 28, 2019
  7. Mar 05, 2019
  8. Jan 31, 2019
  9. Jan 25, 2019
  10. Jan 24, 2019
  11. Jan 23, 2019
    • Jan Provaznik's avatar
      Sent notification only to authorized users · 022f60e8
      Jan Provaznik authored
      When moving a project, it's possible that some users who had
      access to the project in old path can not access the project
      in the new path.
      
      Because `project_authorizations` records are updated asynchronously,
      when we send the notification about moved project the list of project
      team members contains old project members, we want to notify all these
      members except the old users who can not access the new location.
      022f60e8
  12. Dec 06, 2018
  13. Nov 15, 2018
    • Yorick Peterse's avatar
      Refactor Member#add_user for GitLab EE · 0aa386f7
      Yorick Peterse authored
      GitLab EE extends Member#add_user by adding some LDAP specific flags.
      Prior to these changes, the only way this could be done was by modifying
      Member#add_user in place. This could lead to merge conflicts whenever a
      developer wants to change this method.
      
      To resolve this issue, the logic that EE extends has been moved into a
      separate method with the appropriate arguments. This allows EE to extend
      the logic by prepending the method using an EE specific module.
      Unverified
      0aa386f7
  14. Sep 11, 2018
  15. Aug 21, 2018
  16. Jul 26, 2018
  17. Jul 11, 2018
  18. May 10, 2018
  19. Apr 04, 2018
  20. Mar 21, 2018
  21. Mar 11, 2018
  22. Mar 07, 2018
  23. Feb 27, 2018
  24. Feb 14, 2018
  25. Dec 11, 2017
    • TM Lee's avatar
      Refactor member view by using presenter · 2cf3fc18
      TM Lee authored
      
      - Create MemberPresenter alongside with GroupMemberPresenter and ProjectMemberPresenter
      - Make Member model Presentable
      - Move action_member_permission from MembersHelper into the MemberPresenter
      - Added rspec using double, separate specs for GroupMemberPresenter and ProjectMemberPresenter
      
      Fixes #28004.
      
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      2cf3fc18
  26. Dec 05, 2017
  27. Sep 05, 2017
    • Rubén Dávila's avatar
      Optimize SQL queries used in Groups::GroupMembersController#create · 66cfb901
      Rubén Dávila authored
      The following optimizations were performed:
      
      - Add new association to GroupMember and ProjectMember
      
        This new association will allow us to check if a user is a member of a
        Project or Group through a single query instead of two.
      
      - Optimize retrieving of Members when adding multiple Users
      66cfb901
  28. Aug 14, 2017
  29. Aug 11, 2017
  30. Jun 21, 2017
  31. Jun 07, 2017
  32. Jun 05, 2017
    • Sean McGivern's avatar
      Allow group reporters to manage group labels · 5db229fb
      Sean McGivern authored
      Previously, only group masters could do this. However, project reporters can
      manage project labels, so there doesn't seem to be any need to restrict group
      labels further.
      
      Also, save a query or two by getting a single GroupMember object to find out if
      the user is a master or not.
      5db229fb
  33. Apr 28, 2017
  34. Apr 21, 2017
  35. Feb 23, 2017
    • Douwe Maan's avatar
      Revert "Enable Style/DotPosition" · 56de781a
      Douwe Maan authored
      This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.
      
      # Conflicts:
      #	.rubocop.yml
      #	.rubocop_todo.yml
      #	lib/gitlab/ci/config/entry/global.rb
      #	lib/gitlab/ci/config/entry/jobs.rb
      #	spec/lib/gitlab/ci/config/entry/factory_spec.rb
      #	spec/lib/gitlab/ci/config/entry/global_spec.rb
      #	spec/lib/gitlab/ci/config/entry/job_spec.rb
      #	spec/lib/gitlab/ci/status/build/factory_spec.rb
      #	spec/lib/gitlab/incoming_email_spec.rb
      56de781a
    • Douwe Maan's avatar
      Revert "Prefer leading style for Style/DotPosition" · 1fe7501b
      Douwe Maan authored
      This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
      1fe7501b
Loading