Skip to content
Snippets Groups Projects
  1. Mar 17, 2020
  2. Mar 06, 2020
  3. Feb 13, 2020
  4. Feb 05, 2020
  5. Jan 21, 2020
  6. Jan 16, 2020
  7. Jan 15, 2020
  8. Jan 14, 2020
  9. Dec 19, 2019
  10. Dec 17, 2019
  11. Dec 12, 2019
  12. Dec 09, 2019
  13. Dec 04, 2019
  14. Nov 26, 2019
  15. Aug 16, 2019
  16. Jun 14, 2019
  17. May 10, 2019
  18. Apr 12, 2019
  19. Apr 05, 2019
    • Sam Bigelow's avatar
      Improve diff navigation header · bf47270e
      Sam Bigelow authored
      - Compare versions header is full width except in the unified diff mode
      with no tree sidebar
        - Bar is always full width, but the content within stays centered when
      unified and no tree sidebar
      - File header is the same height as the "Compare versions header"
      - aligns with the design system grid guidelines => 56px
      - Diff file headers use a button group, switch icon order to open file
      externally being the last option, all buttons will become icon buttons
      (icon delivery by @dimitrieh)
      - If a file header becomes sticky no rounded corner/double border
      problem is visible anymore
      bf47270e
  20. Mar 19, 2019
  21. Feb 27, 2019
    • Denys Mishunov's avatar
      Set up basic keyboard next/previous navigation in diff list · 0aff8e27
      Denys Mishunov authored
      Mousetrap is used as the help-tool to listen to keystrokes
      
      Added currentDiffIndex getter to store that holds
      the index of currently active diff file in the list
      
      Instead of computing it on the component, we will take advantage of it
      being available for all components in DiffsApp
      
      Testing keyboard navigation and jumpToFile()
      0aff8e27
  22. Feb 15, 2019
  23. Feb 05, 2019
  24. Dec 13, 2018
  25. Nov 30, 2018
  26. Nov 22, 2018
  27. Nov 20, 2018
  28. Nov 16, 2018
  29. Nov 14, 2018
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      Unverified
      234563ba
  30. Nov 09, 2018
  31. Nov 07, 2018
  32. Nov 05, 2018
    • Phil Hughes's avatar
      Re-implemented image commenting on diffs · f7df9ddb
      Phil Hughes authored
      This re-implements image commenting in merge request diffs.
      This feature was previously lost when the merge request
      page was refactored into Vue.
      
      With this, we create an overlay component. The overlay
      component handles displaying the comment badges
      and the comment form badge.
      Badges are displayed based on the position attribute
      sent with the discussion.
      
      Comment forms for diff files are controlled through
      a different state property. This is so we don't
      tie comment forms to diff files directly creating
      deep nested state. Instead we create a flat array
      which holds the file hash & the X & Y position of
      the comment form.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
      Unverified
      f7df9ddb
  33. Oct 30, 2018
  34. Oct 25, 2018
  35. Oct 24, 2018
  36. Oct 06, 2018
  37. Oct 03, 2018
    • Phil Hughes's avatar
      Added file tree to merge request diffs · 33c4c5b8
      Phil Hughes authored
      This file tree displays all the diff files in a tree like format
      Each file is taken and converted into a tree with folders
      Each folder can be toggled open & closed
      Clicking a file will scroll to the diff file & highlight with a glow affect
      
      Searching the tree list will search only files & return a list of the
      files without any folders
      
      Each file row contains an icon to show changed, new file or deleted
      Each row will also contain the added & removed lines count
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
      Unverified
      33c4c5b8
  38. Sep 26, 2018
Loading