Sam Bigelow authored 5 years ago and Paul Slaughter committed 5 years ago

Add keyboard shortcuts `p` and `n` to navigate duscussions.

- expand upwards
- expand downwards
- expand all

in both inline and parallel views

- all commits squashed to make danger review happy

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56523

Correctly updates the URL without overwriting parameters
Reloads the diff file content without reloading the page

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58852, https://gitlab.com/gitlab-org/gitlab-ce/issues/42597

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58597

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53139

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51737

Phil Hughes authored 6 years ago and Mark Chao committed 6 years ago

The user can also toggle between the diff changes and
the full file diff.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/19054

Mousetrap is used as the help-tool to listen to keystrokes

Added currentDiffIndex getter to store that holds
the index of currently active diff file in the list

Instead of computing it on the component, we will take advantage of it
being available for all components in DiffsApp

Testing keyboard navigation and jumpToFile()

Fixes some diff files not rendering when the renderIt
property is updated.
Previously it was using a local copy of renderIt which meant
Vue wouldn't update it when the files renderIt property was updates

- replaced file.too_large
- replaced file.text
- replaced file.collapsed

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51857

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53304

Dropdown includes buttons for tree view rendering mode
and buttons for the compare view (inline or side-by-side)

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55491

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53069

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50662

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54868

Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.

Also tidied up some components to get them closer to our docs.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506

This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.

This changes that & makes it consistent with what it returned from the
API, snake case.

This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.

With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.

Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash & the X & Y position of
the comment form.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956

Also fixed a bug where discussions wouldn't be assigned to a line
when switching from discussion tab to changes tab