Skip to content
Snippets Groups Projects
  1. Mar 17, 2020
  2. Jan 14, 2020
  3. Feb 27, 2019
    • Denys Mishunov's avatar
      Set up basic keyboard next/previous navigation in diff list · 0aff8e27
      Denys Mishunov authored
      Mousetrap is used as the help-tool to listen to keystrokes
      
      Added currentDiffIndex getter to store that holds
      the index of currently active diff file in the list
      
      Instead of computing it on the component, we will take advantage of it
      being available for all components in DiffsApp
      
      Testing keyboard navigation and jumpToFile()
      0aff8e27
  4. Feb 15, 2019
  5. Feb 05, 2019
  6. Jan 08, 2019
  7. Nov 27, 2018
  8. Nov 15, 2018
  9. Nov 14, 2018
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      Unverified
      234563ba
  10. Nov 07, 2018
  11. Nov 05, 2018
    • Phil Hughes's avatar
      Re-implemented image commenting on diffs · f7df9ddb
      Phil Hughes authored
      This re-implements image commenting in merge request diffs.
      This feature was previously lost when the merge request
      page was refactored into Vue.
      
      With this, we create an overlay component. The overlay
      component handles displaying the comment badges
      and the comment form badge.
      Badges are displayed based on the position attribute
      sent with the discussion.
      
      Comment forms for diff files are controlled through
      a different state property. This is so we don't
      tie comment forms to diff files directly creating
      deep nested state. Instead we create a flat array
      which holds the file hash & the X & Y position of
      the comment form.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
      Unverified
      f7df9ddb
  12. Oct 03, 2018
    • Phil Hughes's avatar
      Added file tree to merge request diffs · 33c4c5b8
      Phil Hughes authored
      This file tree displays all the diff files in a tree like format
      Each file is taken and converted into a tree with folders
      Each folder can be toggled open & closed
      Clicking a file will scroll to the diff file & highlight with a glow affect
      
      Searching the tree list will search only files & return a list of the
      files without any folders
      
      Each file row contains an icon to show changed, new file or deleted
      Each row will also contain the added & removed lines count
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
      Unverified
      33c4c5b8
  13. Sep 07, 2018
  14. Aug 08, 2018
  15. Aug 01, 2018
  16. Jul 31, 2018
  17. Jul 23, 2018
  18. Jul 17, 2018
  19. Jul 10, 2018
    • Filipa Lacerda's avatar
      Fixes toggle discussion button not expanding collapsed discussions · ac71675d
      Filipa Lacerda authored
      Discussions were being toggled by jquery DOM querying them and toggling
      visibility but in vue, only the open discussions will be in the DOM
      Fix includes:
       - Adds a getter to the store to get the expanded discussions
       - Adds an action to collapse a discussion
       - When the user clicks the button, all data needed is now accessible
         through a getter and we can dispatch an action to toggle the discussion
         within the state, instead of showing/hiding with jQuery
       - Removes hardcoded properties
      
      Resolves #48237
      Unverified
      ac71675d
  20. Jul 06, 2018
  21. Jun 21, 2018
Loading