Skip to content
Snippets Groups Projects
  1. Feb 14, 2018
  2. Feb 13, 2018
  3. Feb 02, 2018
  4. Jan 22, 2018
  5. Jan 19, 2018
  6. Jan 04, 2018
  7. Nov 23, 2017
  8. Nov 03, 2017
  9. Oct 21, 2017
  10. Oct 20, 2017
  11. Oct 03, 2017
  12. Sep 28, 2017
  13. Sep 22, 2017
  14. Sep 13, 2017
  15. Sep 07, 2017
    • Yorick Peterse's avatar
      Rework how recent push events are retrieved · 83355336
      Yorick Peterse authored
      Whenever you push to a branch GitLab will show a button to create a
      merge request (should one not exist already). The underlying code to
      display this data was quite inefficient. For example, it involved
      multiple slow queries just to figure out what the most recent push event
      was.
      
      This commit changes the way this data is retrieved so it's much faster.
      This is achieved by caching the ID of the last push event on every push,
      which is then retrieved when loading certain pages. Database queries are
      only executed if necessary and the cached data is removed automatically
      once a merge request has been created, or 2 hours after being stored.
      
      A trade-off of this approach is that we _only_ track the last event.
      Previously if you were to push to branch A and B then create a merge
      request for branch B we'd still show the widget for branch A. As of this
      commit this is no longer the case, instead we will only show the widget
      for the branch you pushed to most recently. Once a merge request exists
      the widget is no longer displayed. Alternative solutions are either too
      complex and/or too slow, hence the decision was made to settle for this
      trade-off.
      
      Performance Impact
      ------------------
      
      In the best case scenario (= a user didn't push anything for more than 2
      hours) we perform a single Redis GET per page. Should there be cached
      data we will run a single (and lightweight) SQL query to get the
      event data from the database. If a merge request already exists we will
      run an additional DEL to remove the cache key.
      
      The difference in response timings can vary a bit per project. On
      GitLab.com the 99th percentile of time spent in User#recent_push hovers
      between 100 milliseconds and 1 second, while the mean hovers around 50
      milliseconds. With the changes in this MR the expected time spent in
      User#recent_push is expected to be reduced down to just a few
      milliseconds.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
      Unverified
      83355336
    • Mike Greiling's avatar
    • Maxim Rydkin's avatar
    • Maxim Rydkin's avatar
    • Maxim Rydkin's avatar
      fix helper and spec · 0963ac36
      Maxim Rydkin authored
      Verified
      0963ac36
    • Maxim Rydkin's avatar
      Verified
      db3bc897
  16. Sep 06, 2017
  17. Sep 05, 2017
  18. Aug 31, 2017
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      5883ce95
  19. Aug 29, 2017
  20. Aug 18, 2017
  21. Aug 15, 2017
  22. Aug 14, 2017
  23. Aug 07, 2017
    • Yorick Peterse's avatar
      Improve checking if projects would be returned · f77fda64
      Yorick Peterse authored
      In various places we check if the same relation would return projects.
      This is done using "any?" which will run a COUNT query with any
      LIMIT/OFFSET values still applied.
      
      To work around all this we introduce 2 helper methods that take care of
      doing the right thing. This leads to the produced queries being simpler
      and fewer queries being executed.
      Verified
      f77fda64
  24. Aug 01, 2017
  25. Jul 18, 2017
  26. Jul 13, 2017
Loading