Skip to content
Snippets Groups Projects
  1. Feb 13, 2018
    • Andreas Brandl's avatar
      Extract repeated logic into #avatar_icon_for. · dd1d13b8
      Andreas Brandl authored
      This essentially allows to pass both user and email, so that we can
      either prefer the user to retrieve the avatar or (if user is not
      present) fall back to the email lookup.
      dd1d13b8
    • Andreas Brandl's avatar
      Explicit use of avatar_icon_* calls depending on situation. · c641dff0
      Andreas Brandl authored
      We want to drop the generic #avatar_icon helper that supports both an email
      and a user object being passed in. Instead, we want to explicitly use the #avatar_icon_for_user
      and #avatar_icon_for_email helpers depending on what we have at hand.
      This allows us to avoid unnecessary database queries (e.g. call
      User.find_by_any_email if we already have the user).
      
      In situations like here, this makes it less convenient to use.
      c641dff0
    • Andreas Brandl's avatar
      Use more specific #avatar_icon_for_user. · be231d21
      Andreas Brandl authored
      Whenever we already deal with a User object, let's use the more specific
      method avatar_icon_for_user.
      be231d21
  2. Dec 18, 2017
  3. Oct 02, 2017
  4. Jun 20, 2017
  5. Apr 06, 2017
  6. Feb 22, 2017
  7. Jan 24, 2017
  8. Dec 31, 2016
  9. Dec 06, 2016
  10. Nov 07, 2016
  11. Oct 19, 2016
  12. Oct 13, 2016
  13. Oct 12, 2016
  14. Oct 08, 2016
  15. Oct 07, 2016
  16. Oct 06, 2016
  17. Sep 13, 2016
  18. Aug 31, 2016
Loading