- Apr 16, 2018
-
-
Andreas Brandl authored
This is useful for a transition period to migrate away from `NoninternalAtomicId`. In a situation where both the old and new code to generate a iid value is run at the same time (for example, during a deploy different nodes may serve both versions), this will lead to problems regarding the correct `last_value`. That is, what we track in `InternalId` may get out of sync with the maximum iid present for issues. With this change, we double-check that and correct the `last_value` with the maximum iid found in issues if necessary. This is subject to be removed with the 10.8 release and tracked over here: https://gitlab.com/gitlab-org/gitlab-ce/issues/45389 Closes #45269.
-
- Apr 12, 2018
-
-
blackst0ne authored
Some specs fail in rails5 branch with errors like ``` 1) Group#secret_variables_for when the ref is not protected contains only the secret variables Failure/Error: variables = Ci::GroupVariable.where(group: list_of_ids) NoMethodError: undefined method `arel_table' for Ci::Group:Class ``` This commit fixes it.
-
- Apr 11, 2018
-
-
Michael Kozono authored
-
blackst0ne authored
In Rails 5.0 the `ActiveRecord::Inheritance::subclass_from_attributes` method was updated. Now it calls the `find_sti_class` method [1] which is overriden in the `Event` model and returns needed class (`Event` vs `PushEvent`). [1]: https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/inheritance.rb#L209 This commit fixes the errors like ``` 143) User#contributed_projects doesn't include IDs for unrelated projects Failure/Error: action = attrs.with_indifferent_access[inheritance_column].to_i NoMethodError: undefined method `with_indifferent_access' for nil:NilClass # ./app/models/event.rb:118:in `subclass_from_attributes' ``` which are raised on the `RAILS5=1 rspec ...` command.
-
Bob Van Landuyt authored
This prevents performing the requests, and disables all emoji reaction buttons
-
- Apr 10, 2018
-
-
Douwe Maan authored
-
Mayra Cabrera authored
-
- Apr 09, 2018
-
-
Sean McGivern authored
Goldiloader is great, but has several issues with has_many :through relations: * https://github.com/salsify/goldiloader/issues/12 * https://github.com/salsify/goldiloader/issues/14 * https://github.com/salsify/goldiloader/issues/18 Rather than try to figure out which applies in each case, we should just do the drudge work of manually disabling autoloading for all relations of this type. We can always use regular preloading for specific cases, but this way we avoid generating invalid queries through Goldiloader's magic.
-
Yorick Peterse authored
Goldiloader (https://github.com/salsify/goldiloader) can eager load associations automatically. This removes the need for adding "includes" calls in a variety of different places. This also comes with the added benefit of not having to eager load data if it's not used.
-
Dylan Griffith authored
-
Dylan Griffith authored
Use project_authorizations instead of members to calculate manageable CI projects to speed up query (#41981)
-
Dylan Griffith authored
-
- Apr 07, 2018
-
-
blackst0ne authored
In Rails 5.0 the `ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES` constant has been removed [1] and the remaining `FALSE_VALUES` constant has been moved to `ActiveModel::Type::Boolean` [2] [1]: https://github.com/rails/rails/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61 [2]: https://github.com/rails/rails/commit/9cc8c6f3730df3d94c81a55be9ee1b7b4ffd29f6
-
Mayra Cabrera authored
The TIMESTAMP data type is used for values that contain both date and time parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to '2038-01-19 03:14:07' UTC. A Forever lib class was included to handle future dates for PostgreSQL and MySQL, also changes were made to DeployToken to enforce Forever.date Also removes extra conditional from JwtController
-
Mayra Cabrera authored
-
Mayra Cabrera authored
- Adds a default on expires_at datetime - Modifies deploy tokens views to handle default expires at value - Use datetime_with_timezone where possible - Remove unused scopes
-
Mayra Cabrera authored
Also, fixes broken specs
-
Mayra Cabrera authored
Also: - Changes scopes from serializer to use boolean columns - Fixes broken specs
-
-
Mayra Cabrera authored
- Remove extra method for authorize_admin_project - Ensure project presence - Rename 'read_repo' to 'read_repository' to be more verbose
-
Mayra Cabrera authored
- Keep 'Deploy Section' open upon save, otherwise the token might get lost - When an error appears, display the error inside the form and also keep the Deploy Section open - Changue copy of revoke modal
-
Mayra Cabrera authored
This will allow to download a repo using the token from the DeployToken
-
Mayra Cabrera authored
Includes: - Model, factories, create service and controller actions - As usual, includes specs for everything - Builds UI (copy from PAT) - Add revoke action Closes #31591
-
- Apr 06, 2018
-
-
Oswaldo Ferreir authored
-
-
blackst0ne authored
-
Andreas Brandl authored
-
Andreas Brandl authored
Closes #37462.
-
Grzegorz Bizon authored
-
- Apr 05, 2018
-
-
-
Stan Hu authored
This prevents us from having to manually flush the cache key in migrations every time a new column is added. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/5571
-
m b authored
The merge request counter in the UI was not decreasing when a merge request was deleting. This was just due to the cache not being refreshed on a delete action. fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/44458
-
Felipe Artur authored
-
Felipe Artur authored
-
Bob Van Landuyt authored
Since we can regenerate `description_html` from the `description`, we should not export it. This avoids some complexity when overriding the description during an import/export where we would need to invalidate this cached field. Now we refresh the markdown cache after the import
-
Kamil Trzcińśki authored
-
Jan Provaznik authored
Updates notes-related services and rendering so this code can be easily used for group-scoped resources (specifically Epics). Related to gitlab-ee!5205
-
Douwe Maan authored
-
Bob Van Landuyt authored
This makes accessing LFS Objects for a project easier project.lfs_storage_project.lfs_objects` becomes project.all_lfs_objects This will make the refactor in https://gitlab.com/gitlab-org/gitlab-ce/issues/39769 easier to deal with.
-
Douwe Maan authored
[10.6] Prevent notes on confidential issues from being sent to chat See merge request gitlab/gitlabhq!2366 # Conflicts: # app/helpers/services_helper.rb
-