Skip to content
Snippets Groups Projects
  1. Oct 07, 2019
  2. Oct 03, 2019
  3. Oct 01, 2019
  4. Sep 26, 2019
  5. Oct 10, 2018
    • Zeger-Jan van de Weg's avatar
      Remove Git circuit breaker · 30b4ce94
      Zeger-Jan van de Weg authored
      Was introduced in the time that GitLab still used NFS, which is not
      required anymore in most cases. By removing this, the API it calls will
      return empty responses. This interface has to be removed in the next
      major release, expected to be 12.0.
      Unverified
      30b4ce94
  6. Sep 19, 2018
    • gfyoung's avatar
      Enable frozen string in app/controllers/**/*.rb · 73322a0e
      gfyoung authored
      Enables frozen string for the following:
      
      * app/controllers/*.rb
      * app/controllers/admin/**/*.rb
      * app/controllers/boards/**/*.rb
      * app/controllers/ci/**/*.rb
      * app/controllers/concerns/**/*.rb
      
      Partially addresses #47424.
      73322a0e
  7. Jul 28, 2018
  8. Jun 27, 2018
    • Zeger-Jan van de Weg's avatar
      Gitaly metrics check for read/writeability · 65840591
      Zeger-Jan van de Weg authored
      Prior to this change, health checks checked for writeability of the NFS
      shards. Given we're moving away from that, this patch extends the checks
      for Gitaly to check for read and writeability.
      
      Potentially some dashboards will break, as over time these metrics will
      no longer appear as Prometheus doesn't get the data anymore.
      Observability in the circuit breaker will be reduced, but its not
      expected to be turned on and the circuit breaker is being removed soon
      too.
      
      Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
      Unverified
      65840591
  9. Jun 21, 2018
  10. Jan 24, 2018
  11. Dec 08, 2017
    • Bob Van Landuyt's avatar
      Move the circuitbreaker check out in a separate process · f1ae1e39
      Bob Van Landuyt authored
      Moving the check out of the general requests, makes sure we don't have
      any slowdown in the regular requests.
      
      To keep the process performing this checks small, the check is still
      performed inside a unicorn. But that is called from a process running
      on the same server.
      
      Because the checks are now done outside normal request, we can have a
      simpler failure strategy:
      
      The check is now performed in the background every
      `circuitbreaker_check_interval`. Failures are logged in redis. The
      failures are reset when the check succeeds. Per check we will try
      `circuitbreaker_access_retries` times within
      `circuitbreaker_storage_timeout` seconds.
      
      When the number of failures exceeds
      `circuitbreaker_failure_count_threshold`, we will block access to the
      storage.
      
      After `failure_reset_time` of no checks, we will clear the stored
      failures. This could happen when the process that performs the checks
      is not running.
      f1ae1e39
  12. Jul 11, 2017
  13. Jul 04, 2017
  14. Jun 02, 2017
  15. May 10, 2017
  16. Apr 07, 2017
Loading