- Show if user can_resolve all of the notes

totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded

issuable.discussions makes multiple requests, so
too expensive for this

This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast

Call QuickActionsService on Note update

Add support for notes which just contain
commands after editing

Return http status gone (410) if note was deleted

Temporary frontend addition so it is not
failing when a note is deleted

Move specs to shared examples

Fix rubocop style issue

Deleting note on frontend when status is 410

Use guard clause for note which got deleted

Simplified condition for nil note

This method should no longer be called
with nil note

Refactoring of execute method to reduce
complexity

Move errors update to delete_note method

Note is now deleted visually when it only
contains commands after update

Add expectation

Fix style issues

Changing action to fix tests

Add tests for removeNote and update
deleteNote expectations

Also adds comment to explain why this works on the diff-tab
when it's only used in `notes-app`.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30144#note_204066538

Sam Bigelow authored 5 years ago and Paul Slaughter committed 5 years ago

Add keyboard shortcuts `p` and `n` to navigate duscussions.

Disables the vue-i18n eslint rules for files
that are not able to be autofixed, this will
stop these offences causing pipeline failures
but they will need manual fixing.

Send a `persist_filter: false` param to backend when
opening links to notes and auto-switching to show
all notes

Tomislav Nikic authored 5 years ago and Daniel Davison committed 5 years ago

All the changes done to files that are also inside CE and need to be
ported.

eTagPoll may not be initialized yet when we save a note.
Polling is initialized only after discussions are loaded