GitalyBot authored 5 years ago and Bob Van Landuyt :neckbeard: committed 5 years ago

The setup was wrong, and due to Gitaly being a bit more strict it had to
match up. The test is now accurate and passing again.

This couples the code that transitions the `MergeRequest#merge_status`
and refs/merge-requests/:iid/merge ref update.

In general, instead of directly telling `MergeToRefService` to update
the merge ref, we should rely on `MergeabilityCheckService` to keep
both the merge status and merge ref synced. Now, if the merge_status is
`can_be_merged` it means the merge-ref is also updated to the latest.

We've also updated the logic to be more systematic and less user-based.