Skip to content
Snippets Groups Projects
  1. Jan 24, 2018
  2. Jan 11, 2018
  3. Dec 22, 2017
  4. Oct 09, 2017
  5. Sep 19, 2017
    • Yorick Peterse's avatar
      Fix refreshing of issues/MR count caches · 57b96eb6
      Yorick Peterse authored
      This ensures the open issues/MR count caches are refreshed properly when
      creating new issues or MRs. This MR also includes a change to the cache
      keys to ensure all caches are rebuilt on the fly.
      
      This particular problem was not caught in the test suite due to a null
      cache being used, resulting in all calls that would use a cache using
      the underlying data directly. In production the code would fail because
      a newly saved record returns an empty hash in #changes meaning checks
      such as `state_changed? || confidential_changed?` would return false for
      new rows, thus never updating the counters.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
      Verified
      57b96eb6
  6. Sep 14, 2017
  7. Sep 01, 2017
    • Robert Speicher's avatar
      Fix a spec failure dependent on load order · 7cc19cd5
      Robert Speicher authored
      We were incorrectly stubbing `Issues::MoveService#execute`. This only
      caused a failure when another spec caused it to be autoloaded --
      `spec/controllers/projects/issues_controller_spec.rb` in this case.
      7cc19cd5
  8. Aug 31, 2017
  9. Aug 29, 2017
  10. Aug 23, 2017
    • Yorick Peterse's avatar
      Cache the number of open issues and merge requests · 6ec53f5d
      Yorick Peterse authored
      Every project page displays a navigation menu that in turn displays the
      number of open issues and merge requests. This means that for every
      project page we run two COUNT(*) queries, each taking up roughly 30
      milliseconds on GitLab.com. By caching these numbers and refreshing them
      whenever necessary we can reduce loading times of all these pages by up
      to roughly 60 milliseconds.
      
      The number of open issues does not include confidential issues. This is
      a trade-off to keep the code simple and to ensure refreshing the data
      only needs 2 COUNT(*) queries instead of 3. A downside is that if a
      project only has 5 confidential issues the counter will be set to 0.
      
      Because we now have 3 similar counting service classes the code
      previously used in Projects::ForksCountService has mostly been moved to
      Projects::CountService, which in turn is reused by the various service
      classes.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36622
      Verified
      6ec53f5d
  11. Aug 09, 2017
  12. Aug 03, 2017
    • Lin Jen-Shin's avatar
      Don't include EmailHelpers manually, pick with rspec · bb5f79d4
      Lin Jen-Shin authored
      `:mailer` is needed to pick it easily, while
      `type: :mailer` is needed for picking it automatically for
      tests located in spec/mailers/*_spec.rb
      
      It's a bit complicated in spec/services/notification_service_spec.rb
      but we'll leave it alone for now.
      bb5f79d4
  13. Aug 02, 2017
  14. Jul 27, 2017
  15. Jul 24, 2017
  16. Jul 21, 2017
  17. Jul 20, 2017
  18. Jul 07, 2017
  19. Jun 21, 2017
  20. Jun 15, 2017
  21. Jun 14, 2017
  22. Jun 12, 2017
  23. May 26, 2017
  24. May 15, 2017
  25. May 12, 2017
  26. May 10, 2017
  27. May 05, 2017
  28. May 04, 2017
  29. Apr 26, 2017
  30. Apr 05, 2017
  31. Mar 29, 2017
Loading