Skip to content
Snippets Groups Projects
  1. Jan 28, 2020
  2. Dec 20, 2019
  3. Nov 19, 2019
  4. Oct 22, 2019
    • Kerri Miller's avatar
      Avoid #authenticate_user! in #route_not_found · 2a4457ea
      Kerri Miller authored
      This method, #route_not_found, is executed as the final fallback for
      unrecognized routes (as the name might imply.) We want to avoid
      `#authenticate_user!` when calling `#route_not_found`;
      `#authenticate_user!` can, depending on the request format, return a 401
      instead of redirecting to a login page. This opens a subtle security
      exploit where anonymous users will receive a 401 response when
      attempting to access a private repo, while a recognized user will
      receive a 404, exposing the existence of the private, hidden repo.
      2a4457ea
    • GitLab Bot's avatar
  5. Sep 13, 2019
  6. Aug 31, 2019
  7. Aug 15, 2019
  8. Aug 14, 2019
  9. Aug 08, 2019
  10. Jul 25, 2019
  11. Jul 23, 2019
  12. Jun 26, 2019
  13. Jun 05, 2019
  14. May 31, 2019
    • Bob Van Landuyt's avatar
      Setup Phabricator import · 589b2db0
      Bob Van Landuyt authored
      This sets up all the basics for importing Phabricator tasks into
      GitLab issues.
      
      To import all tasks from a Phabricator instance into GitLab, we'll
      import all of them into a new project that will have its repository
      disabled.
      
      The import is hooked into a regular ProjectImport setup, but similar
      to the GitHub parallel importer takes care of all the imports itself.
      
      In this iteration, we're importing each page of tasks in a separate
      sidekiq job.
      
      The first thing we do when requesting a new page of tasks is schedule
      the next page to be imported. But to avoid deadlocks, we only allow a
      single job per worker type to run at the same time.
      
      For now we're only importing basic Issue information, this should be
      extended to richer information.
      589b2db0
  15. May 02, 2019
  16. Apr 18, 2019
  17. Apr 08, 2019
  18. Feb 26, 2019
  19. Feb 12, 2019
    • Stan Hu's avatar
      Log queue duration in production_json.log · 51ca7922
      Stan Hu authored
      `queue_duration` is a useful metric that is currently in api_json.log
      but not in production_json.log. We should add it because it tells us how
      long the request sat in Workhorse before Unicorn processed it. Having
      this field enables the support team to better troubleshoot when delays
      began to happen.
      51ca7922
  20. Jan 15, 2019
  21. Jan 02, 2019
  22. Dec 19, 2018
  23. Dec 16, 2018
  24. Dec 06, 2018
  25. Nov 29, 2018
  26. Nov 23, 2018
  27. Nov 18, 2018
  28. Nov 15, 2018
  29. Oct 23, 2018
  30. Oct 13, 2018
    • Jan Provaznik's avatar
      Use InvalidUTF8ErrorHandler only for rails 4 · c6a4c923
      Jan Provaznik authored
      In Rails 5 catches invalid UTF8 characters in querystring in a
      params middleware, errors are handled by a params middleware and
      raises a BadRequest exception. This means that these UTF8 errors
      are not raised deeper in application stack and these can't also
      be handled on application level.
      
      If we would want to have custom handler for these errors, we would
      have to create a new middleware and insert it before actionpack's
      params middleware and rescue BadRequest exceptions there. But there
      is no need to do this currently (see discussion on
      https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
      c6a4c923
  31. Oct 10, 2018
    • Zeger-Jan van de Weg's avatar
      Remove Git circuit breaker · 30b4ce94
      Zeger-Jan van de Weg authored
      Was introduced in the time that GitLab still used NFS, which is not
      required anymore in most cases. By removing this, the API it calls will
      return empty responses. This interface has to be removed in the next
      major release, expected to be 12.0.
      Unverified
      30b4ce94
  32. Oct 08, 2018
  33. Oct 01, 2018
  34. Sep 26, 2018
  35. Sep 22, 2018
  36. Sep 19, 2018
    • gfyoung's avatar
      Enable frozen string in app/controllers/**/*.rb · 73322a0e
      gfyoung authored
      Enables frozen string for the following:
      
      * app/controllers/*.rb
      * app/controllers/admin/**/*.rb
      * app/controllers/boards/**/*.rb
      * app/controllers/ci/**/*.rb
      * app/controllers/concerns/**/*.rb
      
      Partially addresses #47424.
      73322a0e
  37. Sep 07, 2018
Loading