Skip to content
Snippets Groups Projects
  1. Dec 13, 2019
  2. Dec 12, 2019
  3. Dec 09, 2019
  4. Dec 04, 2019
  5. Nov 26, 2019
  6. Sep 12, 2019
    • Illya Klymov's avatar
      Refactor DiffFileHeader tests · bbdad735
      Illya Klymov authored
      * Switched from Karma to Jest
      * Reorganized tests to have correct semantics
      * Removed unused computed properties from component
      bbdad735
  7. Aug 10, 2019
  8. Jul 03, 2019
  9. Jun 14, 2019
  10. Jun 05, 2019
  11. May 10, 2019
  12. May 03, 2019
  13. Mar 19, 2019
  14. Mar 11, 2019
  15. Mar 06, 2019
  16. Feb 27, 2019
    • Denys Mishunov's avatar
      Set up basic keyboard next/previous navigation in diff list · 0aff8e27
      Denys Mishunov authored
      Mousetrap is used as the help-tool to listen to keystrokes
      
      Added currentDiffIndex getter to store that holds
      the index of currently active diff file in the list
      
      Instead of computing it on the component, we will take advantage of it
      being available for all components in DiffsApp
      
      Testing keyboard navigation and jumpToFile()
      0aff8e27
  17. Feb 18, 2019
    • Phil Hughes's avatar
      Fix diff files not rendering · 512f9624
      Phil Hughes authored
      Fixes some diff files not rendering when the renderIt
      property is updated.
      Previously it was using a local copy of renderIt which meant
      Vue wouldn't update it when the files renderIt property was updates
      Unverified
      512f9624
  18. Feb 15, 2019
  19. Jan 24, 2019
  20. Dec 08, 2018
  21. Dec 05, 2018
  22. Dec 04, 2018
  23. Nov 30, 2018
  24. Nov 27, 2018
  25. Nov 15, 2018
  26. Nov 14, 2018
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      Unverified
      234563ba
  27. Nov 05, 2018
    • Phil Hughes's avatar
      Re-implemented image commenting on diffs · f7df9ddb
      Phil Hughes authored
      This re-implements image commenting in merge request diffs.
      This feature was previously lost when the merge request
      page was refactored into Vue.
      
      With this, we create an overlay component. The overlay
      component handles displaying the comment badges
      and the comment form badge.
      Badges are displayed based on the position attribute
      sent with the discussion.
      
      Comment forms for diff files are controlled through
      a different state property. This is so we don't
      tie comment forms to diff files directly creating
      deep nested state. Instead we create a flat array
      which holds the file hash & the X & Y position of
      the comment form.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
      Unverified
      f7df9ddb
  28. Oct 25, 2018
  29. Oct 24, 2018
  30. Oct 03, 2018
    • Phil Hughes's avatar
      Added file tree to merge request diffs · 33c4c5b8
      Phil Hughes authored
      This file tree displays all the diff files in a tree like format
      Each file is taken and converted into a tree with folders
      Each folder can be toggled open & closed
      Clicking a file will scroll to the diff file & highlight with a glow affect
      
      Searching the tree list will search only files & return a list of the
      files without any folders
      
      Each file row contains an icon to show changed, new file or deleted
      Each row will also contain the added & removed lines count
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
      Unverified
      33c4c5b8
  31. Oct 01, 2018
    • Mark Chao's avatar
      Fix MR discussion not loaded issue · f09303b0
      Mark Chao authored
      Display `formatter` as the sole content of `position` object.
      This means `diff_file` data is not referenced, which is the
      caseu of "IOError: not opened for reading".
      f09303b0
  32. Sep 21, 2018
  33. Sep 20, 2018
  34. Sep 17, 2018
  35. Sep 08, 2018
  36. Sep 07, 2018
Loading