Brett Walker authored 5 years ago and Paul Slaughter committed 5 years ago

- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level

Some of the tests fail locally due to the git user being different
than it is on the test runners.   I'd really like to be able to run
all of the tests locally.

Reuben Pereira authored 5 years ago and Bob Van Landuyt :neckbeard: committed 5 years ago

- On Operations settings page
- On Metrics dashboard page

Part of single codebase changes.

Un-nest title variable output

Update spec test names

Rename sort_value_most_stars -> sort_value_stars_desc

Rename sorted_by_stars -> sorted_by_stars_desc

Renname sort_value_most_stars_asc -> sort_value_stars_asc

Invert feature check, assign feature condition to a variable

Inline conditional nav bar rendering

Invert conditional label

Added follow up task

Fix filters returning 0 projects show the wrong view

Move click action out of test expectation

Use proper variable name for project in before block

Rename projects_sort_admin_options_hash

Renamed projects_sort_admin_options_has to
old_projects_sort_options_hash as its not only used
on the admin screen

Fix extra whitespace errors

Stub project_list_filter_bar in the projects_helper specs

Added follow up task for `show_projects?`

Removed url test expectations

Signed-off-by: Rémy Coutable <remy@rymai.me>

- Move some specs into contexts
- Let get_slugs method take a parameter and return a specific slug.
- Add rescues when using Addressable::URI.

This engine was replaced with CommonMarker in 11.4, it was deprecated
since then.

When the external wiki is enabled, the internal wiki link is replaced
by the external wiki url. But the internal wiki is still accessible.
In this change the external wiki will have its own tab in the sidebar
and only if the services are disabled the tab (and access rights)
will not be displayed.

When the external wiki is enabled, the internal wiki link is replaced
by the external wiki url. But the internal wiki is still accessible.
In this change the external wiki will have its own tab in the sidebar
and only if the services are disabled the tab (and access rights)
will not be displayed.

ADO banner is being hidden if:
- Project has no CI configuration
- Project has CI disabled

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52446

- add tests for merge_request_count
- add tests for show_issue_count
- add tests for explore_projects_tab
- change interface for show_merge_request_count and show_issue_count

There is a combination of few strategies implemented here:

1. Few relations were eager loaded
2. Changed few polymorphic routes to specific ones so we don't have to
   use `#becomes(Namespace)` which doesn't preserve association cache

This method is unneeded given its been pushed to Gitaly, through
https://gitlab.com/gitlab-org/gitaly/merge_requests/780

Closes https://gitlab.com/gitlab-org/gitaly/issues/1235

The partial using this cache key was showing stale information due to
the cache not being invalidated.

Direct disk access is done through Gitaly now, so the legacy path was
deprecated. This path was used in Gitlab::Shell however. This required
the refactoring in this commit.

Added is the removal of direct path access on the project model, as that
lookup wasn't needed anymore is most cases.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1111