Skip to content
Snippets Groups Projects
  1. Sep 26, 2019
  2. Mar 06, 2019
  3. Feb 18, 2019
  4. Feb 14, 2019
  5. Feb 06, 2019
  6. Jan 22, 2019
    • Douwe Maan's avatar
      Trim first char of diff line text on diff discussions · 03df54b2
      Douwe Maan authored
      Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
      diff discussion `truncated_diff_lines` were inconsistent: `text` and
      `rich_text` on the latter included the leading +/-/<space> character,
      like on the backend, while the former had no `text` and its `rich_text`
      had dropped this char.
      
      This resulted in a bug when the suggestions feature expected these diff
      line objects to be identical in format and thus interchangeable, which
      was not the case.
      Unverified
      03df54b2
  7. Dec 13, 2018
  8. Dec 10, 2018
  9. Dec 08, 2018
  10. Dec 04, 2018
  11. Nov 27, 2018
  12. Nov 14, 2018
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      Unverified
      234563ba
  13. Nov 05, 2018
  14. Oct 23, 2018
  15. Sep 21, 2018
    • Phil Hughes's avatar
      Use returned discussion from API · 2497c29e
      Phil Hughes authored and André Luís's avatar André Luís committed
      We now use the returned discussion instead of re-fetching
      all of the discussions and filtering out the ones we don't need.
      This speeds up the process of creating a diff discussions
      by saving us another API request before we can render the discussion
      2497c29e
  16. Sep 18, 2018
  17. Sep 13, 2018
  18. Sep 07, 2018
  19. Aug 01, 2018
  20. Jul 23, 2018
  21. Jul 10, 2018
    • Filipa Lacerda's avatar
      Fixes toggle discussion button not expanding collapsed discussions · ac71675d
      Filipa Lacerda authored
      Discussions were being toggled by jquery DOM querying them and toggling
      visibility but in vue, only the open discussions will be in the DOM
      Fix includes:
       - Adds a getter to the store to get the expanded discussions
       - Adds an action to collapse a discussion
       - When the user clicks the button, all data needed is now accessible
         through a getter and we can dispatch an action to toggle the discussion
         within the state, instead of showing/hiding with jQuery
       - Removes hardcoded properties
      
      Resolves #48237
      Unverified
      ac71675d
  22. Jul 09, 2018
  23. Jun 29, 2018
  24. Jun 21, 2018
  25. Mar 16, 2018
  26. Mar 12, 2018
  27. Mar 10, 2018
  28. Mar 09, 2018
  29. Feb 28, 2018
  30. Feb 09, 2018
  31. Nov 30, 2017
  32. Sep 22, 2017
  33. Aug 22, 2017
  34. Aug 02, 2017
  35. Jul 29, 2017
Loading