when params[:ref_name] is set to "" by passing an empty query parameter
to the api it is evaluated as false by the || operator.
The use of active support core extensions presence method fixes the original
implemantation.

https://guides.rubyonrails.org/active_support_core_extensions.html#presence

When passing start_branch on committing from the WebIDE, it's possible
that the branch has changed since editing started, which results in the
change being applied on top of the latest commit in the branch and
overwriting the new changes.

By passing the start_sha instead we can make sure that the change is
applied on top of the commit which the user started editing from.

Francisco Javier López authored 5 years ago and Nick Thomas committed 5 years ago

This MR refactor RedisCounter and WebIdeCommitsCounter
to be reused by other components.

Francisco Javier López authored 5 years ago and James Lopez committed 5 years ago

We're adding more redis base counters to the web ide and other
classes. We're refactoring this class in other to use the logic
in other places.

This extends POST#:id/repository/commits to allow the optional parameter
`:start_project`, which will allow targeting other projects besides the
one derived from `:id`.

Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/50850

Patrick Bajao authored 6 years ago and Nick Thomas committed 6 years ago

When `force` is set to `true` and `start_branch` is set, the
branch will be ovewritten with the new commit based on the
`HEAD` of the `start_branch`.

This commit includes changes to update the `gitaly-proto` gem.

It also renames the API::PROJECT_ENDPOINT_REQUIREMENTS constant to
API::NAMESPACE_OR_PROJECT_REQUIREMENTS

Previously, we just fetched the latest commit for the given branch when
presenting the resulting commit, but because something could have been
committed to that branch between the time we cherry-picked and the time
we render the result, the wrong commit could have been presented.

Now, we fetch the commit object with the commit SHA returned by the
commit change service, which should always be the correct commit.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53773

This makes a temporary implementation of the
Web IDE commits counter using Redis while
https://gitlab.com/gitlab-org/gitlab-ce/issues/52096
is being discussed further for a more generic
approach to counters

Implements UsageCounters model to track feature usage counters
and makes easy to extend for future counters

Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190

With this action the user can update the execute_filemode of a given file in the repository.

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.

These APIs are used by the web IDE.

They need to be on par with git & web access, allowing edits from
maintainers to forks with merge requests that allow access.

- Original work for the web interface here:
 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13713

Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.

Use Commit#notes and Note.for_commit_id when possible to make sure we use all the indexes available to us