Skip to content
Snippets Groups Projects
  1. Oct 09, 2013
  2. Jul 18, 2013
    • Izaak Alpert's avatar
      Style changes from review with @randx · d9959427
      Izaak Alpert authored
      -Some changes around calling origional methods for !for_fork? merge requests. Other changes to follow
      
      Change-Id: I009c716ce2475b9efa3fd07aee9215fca7a1c150
      d9959427
    • Izaak Alpert's avatar
      Merge Request on forked projects · 3d7194f0
      Izaak Alpert authored
      The good:
      
       - You can do a merge request for a forked commit and it will merge properly (i.e. it does work).
       - Push events take into account merge requests on forked projects
       - Tests around merge_actions now present, spinach, and other rspec tests
       - Satellites now clean themselves up rather then recreate
      
      The questionable:
      
       - Events only know about target projects
       - Project's merge requests only hold on to MR's where they are the target
       - All operations performed in the satellite
      
      The bad:
      
        -  Duplication between project's repositories and satellites (e.g. commits_between)
      
      (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos)
      
      Fixes:
      
      Make test repos/satellites only create when needed
      -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap)
      -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually
      -fixed remote removal
      -How to merge renders properly
      -Update emails to show project/branches
      -Edit MR doesn't set target branch
      -Fix some failures on editing/creating merge requests, added a test
      -Added back a test around merge request observer
      -Clean up project_transfer_spec, Remove duplicate enable/disable observers
      -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well
      -Signifant speed ups for tests
      -Update formatting ordering in notes_on_merge_requests
      -Remove wiki schema update
      Fixes for search/search results
      -Search results was using by_project for a list of projects, updated this to use in_projects
      -updated search results to reference the correct (target) project
      -udpated search results to print both sides of the merge request
      
      Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
      3d7194f0
  3. Jul 12, 2013
  4. Jul 08, 2013
  5. Jun 22, 2013
  6. Jun 06, 2013
  7. May 23, 2013
  8. May 14, 2013
  9. May 07, 2013
  10. May 06, 2013
  11. May 02, 2013
  12. May 01, 2013
  13. Apr 10, 2013
  14. Apr 01, 2013
  15. Mar 25, 2013
  16. Mar 05, 2013
  17. Feb 27, 2013
  18. Feb 21, 2013
  19. Feb 20, 2013
  20. Feb 16, 2013
    • Sebastian Ziebell's avatar
      API: fixes visibility of project hook · e9d3b965
      Sebastian Ziebell authored
      When a user is not authorized to see the list of hooks for a project, he is
      still able to access the hooks separately. For example if access to
      `GET /projects/:id/hooks` fails and returns a `403 Unauthorized` error it is
      still possible to access a hook directly via `GET /projects/:id/hooks/:hook_id`.
      
      Fixes access, also added tests to check access and status codes of hooks.
      e9d3b965
  21. Feb 14, 2013
  22. Feb 13, 2013
  23. Feb 12, 2013
    • Sebastian Ziebell's avatar
      API: changed status codes for project hooks functions · 7cc4339f
      Sebastian Ziebell authored
      Different status codes in the API lib are returned on hook creation, update or deletion.
      If a required parameter is not given (e.g. `url` in `/projects/:id/hooks/:hook_id`) status
      code 400 (Bad request) is returned. On hook deletion a 200 status code is returned, regardless if
      the hook is present or not. This makes the DELETE function an idempotent operation. Appropriate tests
      are added to check these status codes.
      7cc4339f
  24. Feb 08, 2013
Loading