Skip to content
Snippets Groups Projects
  1. Apr 17, 2018
  2. Feb 22, 2018
    • Sean McGivern's avatar
      Fix 500 error when diff context line has broken encoding · cdf3ae04
      Sean McGivern authored
      Rugged sometimes chops a context line in between bytes, resulting in the context
      line having an invalid encoding: https://github.com/libgit2/rugged/issues/716
      
      When that happens, we will try to detect the encoding for the diff, and
      sometimes we'll get it wrong. If that difference in encoding results in a
      difference in string lengths between the diff and the underlying blobs, we'd
      fail to highlight any inline diffs, and return a 500 status to the user.
      
      As we're using the underlying blobs, the encoding is 'correct' anyway, so if the
      string range is invalid, we can just discard the inline diff highlighting. We
      still report to Sentry to ensure that we can investigate further in future.
      cdf3ae04
  3. Jan 11, 2018
  4. Jun 08, 2017
  5. May 23, 2017
  6. Feb 23, 2017
  7. Aug 03, 2016
  8. Jul 06, 2016
  9. Jan 29, 2016
  10. Jan 22, 2016
  11. Jan 20, 2016
  12. Jan 15, 2016
  13. Jan 14, 2016
  14. Jan 13, 2016
  15. Jan 12, 2016
  16. Jan 09, 2016
  17. Jan 08, 2016
  18. Dec 31, 2015
  19. Dec 30, 2015
Loading