Previously, when the wiki page format was anything other than `markdown`
or `asciidoc` the formatted content would be returned though a Gitaly
call. Gitaly in turn would delegate formatting to the gitlab-gollum-lib
gem, which in turn would delegate that to various gems (like RDoc for
`rdoc`) and then apply some very liberal sanitization.

It was too liberal!

This change brings our wiki content formatting in line with how we
format other markdown at GitLab, so we have a SSOT for sanitization.

https://gitlab.com/gitlab-org/gitlab/issues/30540

Igor Drozdov authored 5 years ago and Douwe Maan committed 5 years ago

If a page has the same name as a directory
the WikiPage#group_by_directory method can have
a wrong behaviour

This commit fixes it

Igor Drozdov authored 5 years ago and Douwe Maan committed 5 years ago

- Add controls for sorting by title and date
- Execute Gitaly call which now accepts sorting params for wikis

This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points

Currently, we assume a "last_version" always exists for a wiki page.
In production, this is not always true. So, guard uses of it with a
null check.

Cleanup code, and refactor tests that still use Rugged. After this, there should
be no Rugged code that access the instance's repositories on non-test
environments. There is still some rugged code for other tasks like the
repository import task, but since it doesn't access any repository storage path
it can stay.

Partially addresses #47424.

Closes gitaly#958

The special characters of a wiki title are now escaped correctly.

- Added method to check if the current Page version is the current latest version
- Conditionally checks for current version when showing Edit button
- Added feature specs for viewing project wiki page and expect edit button
- Added Changelog

This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.