Skip to content
Snippets Groups Projects
  1. Sep 19, 2019
  2. Jun 26, 2019
    • Stan Hu's avatar
      Allow caching of negative FindCommit matches · 52215e89
      Stan Hu authored
      When FindCommit ref caching is enabled, negative matches would
      previously not be cached. However, if a source branch is deleted,
      there's no need to keep looking up the same commit. This change caches
      the result of a nil commit.
      52215e89
  3. May 20, 2019
  4. Apr 25, 2019
  5. Mar 27, 2019
    • Stan Hu's avatar
      Allow ref name caching CommitService#find_commit · db759c5d
      Stan Hu authored
      For a given merge request, it's quite common to see duplicate FindCommit
      Gitaly requests because the Gitaly CommitService caches the request by
      the commit SHA, not by the ref name. However, most of the duplicate
      requests use the ref name, so the cache is never actually used in
      practice. This leads to unnecessary requests that slow performance.
      
      This commit allows certain callers to bypass the ref name to
      OID conversion in the cache. We don't do this by default because it's
      possible the tip of the branch changes during the commit, which
      would cause the caller to get stale data.
      
      This commit also forces the Ci::Pipeline to use the full ref name
      so that caching can work for merge requests.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
      db759c5d
  6. Feb 07, 2019
  7. Nov 13, 2018
    • gfyoung's avatar
      Enable even more frozen string in lib/gitlab · ebf98f27
      gfyoung authored
      Enables frozen string for the following:
      
      * lib/gitlab/fogbugz_import/**/*.rb
      * lib/gitlab/gfm/**/*.rb
      * lib/gitlab/git/**/*.rb
      * lib/gitlab/gitaly_client/**/*.rb
      * lib/gitlab/gitlab_import/**/*.rb
      * lib/gitlab/google_code_import/**/*.rb
      * lib/gitlab/gpg/**/*.rb
      * lib/gitlab/grape_logging/**/*.rb
      * lib/gitlab/graphql/**/*.rb
      * lib/gitlab/graphs/**/*.rb
      * lib/gitlab/hashed_storage/**/*.rb
      * lib/gitlab/health_checks/**/*.rb
      
      Partially address gitlab-org/gitlab-ce#47424.
      ebf98f27
  8. Oct 01, 2018
  9. Sep 24, 2018
  10. Sep 17, 2018
  11. Sep 11, 2018
  12. Sep 06, 2018
  13. Jul 09, 2018
  14. Jul 05, 2018
  15. Jun 29, 2018
    • Sean McGivern's avatar
      Fix MR diffs created with gitaly_diff_between enabled · 2c2422d5
      Sean McGivern authored
      When we save merge request diffs to the database, we need to expand the diff
      before doing so. That's so that we can expand diffs (within the normal limits)
      without hitting the repository, but just by going to the database.
      
      This is done implicitly - diffs are expanded unless we say otherwise. However,
      we have another option we can pass, that lets us enforce diff size limits, that
      defaults to true.
      
      Prior to this commit:
      
      - The Rugged code path defaulted to setting `expanded: true` and
        `enforce_limits: true`.
      - The Gitaly code path defaulted to setting `expanded: false` and
        `enforce_limits: true`.
      
      This was introduced by eb36fa17, which
      implemented the initial feature. Since then, if the `gitaly_diff_between`
      feature flag was enabled, MRs would have diffs that could not be expanded in
      some cases, with no fix other than to disable the feature flag and force push to
      the MR to refresh the diff in the database.
      2c2422d5
  16. Jun 27, 2018
  17. Jun 26, 2018
  18. Jun 13, 2018
  19. May 31, 2018
  20. May 30, 2018
  21. May 18, 2018
  22. Apr 12, 2018
  23. Mar 02, 2018
  24. Mar 01, 2018
  25. Feb 26, 2018
  26. Feb 07, 2018
  27. Jan 31, 2018
  28. Jan 25, 2018
  29. Jan 23, 2018
  30. Jan 18, 2018
  31. Jan 15, 2018
  32. Dec 28, 2017
  33. Dec 27, 2017
  34. Dec 19, 2017
    • Zeger-Jan van de Weg's avatar
      Load commit in batches for pipelines#index · c6edae38
      Zeger-Jan van de Weg authored
      Uses `list_commits_by_oid` on the CommitService, to request the needed
      commits for pipelines. These commits are needed to display the user that
      created the commit and the commit title.
      
      This includes fixes for tests failing that depended on the commit
      being `nil`. However, now these are batch loaded, this doesn't happen
      anymore and the commits are an instance of BatchLoader.
      Unverified
      c6edae38
  35. Dec 05, 2017
  36. Nov 29, 2017
  37. Nov 02, 2017
  38. Oct 03, 2017
Loading