Skip to content
Snippets Groups Projects
  1. Jul 30, 2018
  2. Jul 24, 2018
  3. May 04, 2018
    • Bob Van Landuyt's avatar
      Make the user dropdown reusable · 17b25bd2
      Bob Van Landuyt authored
      We will reuse the the dropdown, but exclude some menu items based on
      permissions.
      
      So moving the menu to a partial, and adding checks for each menu item here.
      17b25bd2
  4. Jun 30, 2017
    • Timothy Andrew's avatar
      Implement review comments for !12445 from @godfat and @rymai. · 3c88a786
      Timothy Andrew authored
      - Use `GlobalPolicy` to authorize the users that a non-authenticated user can
        fetch from `/api/v4/users`. We allow access if the `Gitlab::VisibilityLevel::PUBLIC`
        visibility level is not restricted.
      
      - Further, as before, `/api/v4/users` is only accessible to unauthenticated users if
        the `username` parameter is passed.
      
      - Turn off `authenticate!` for the `/api/v4/users` endpoint by matching on the actual
        route + method, rather than the description.
      
      - Change the type of `current_user` check in `UsersFinder` to be more
        compatible with EE.
      3c88a786
  5. Jun 27, 2017
  6. Feb 24, 2017
    • Timothy Andrew's avatar
      Don't allow deleting a ghost user. · 6fdb17cb
      Timothy Andrew authored
      - Add a `destroy_user` ability. This didn't exist before, and was implicit in
        other abilities (only admins could access the admin area, so only they could
        destroy all users; a user can only access their own account page, and so can
        destroy only themselves).
      
      - Grant this ability to admins, and when the current user is trying to destroy
        themselves. Disallow destroying ghost users in all cases.
      
      - Modify the `Users::DestroyService` to check this ability. Also check it in
        views to decide whether or not to show the "Delete User" button.
      
      - Add a short summary of the Ghost User to the bio.
      Unverified
      6fdb17cb
  7. Aug 30, 2016
Loading