This prevents a MITM attack where attacker could
still access Git repository if any jobs were
running long enough.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32554 removed the
support_bot column, but nodes were not told to ignore this column.
As a result, after the post-deploy migration ran, nodes attempted
to use this column, causing 500 errors.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/67295

Dmitriy Zaporozhets authored 5 years ago and Peter Leitzen committed 5 years ago

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

It consists of two parts:

1. Redirecting users to the configured external storage
1. Allowing the external storage to request the static object(s)
   on behalf of the user by means of specific tokens

Part of https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6829

Because we don't have any destroy callbacks (or other logic
triggered on event destroy), there is no reason for deleting events
inefficiently one by one, instead we can use :delete_all.

This is to accomodate prepended modules.

Removed unused method for name setter method

Devise checks before updating any of the authentication_keys if it
needs to clear the reset_password_tokens.

This should fix:
https://gitlab.com/gitlab-org/gitlab-ce/issues/42733 (Weak
authentication and session management)

to 30 days

Expose time since starring on project/:id/starrers API endpoint; exclude private profiles here as well

When a user's notification email is set for a group, we
should use that for pipeline emails

Adam Hegyi authored 5 years ago and Mayra Cabrera committed 5 years ago

- Background migration for changing null values to false
- Set false as default value for private_profile DB column

Instead of setting the name of the namespace to the user's username,
set it to the user's name.

This is more consistent with how we name the routes:
The route-name of a namespace is the human name of the routable. In
the case of a user-namespace, this is the owner's name.

When we change a user's name (both on create and update), we now also
update the namespace-name to the user's name. This will make sure that
if we also correctly update all the nested routes.

The introduction of the in-memory cache for application settings had a
side effect of making it harder to invalidate changes when the settings
occur. We now bypass the cache because it's possible the admin enabled
the usage ping, and we don't want to annoy the user again if they
already set the value.

To avoid causing significant load on the system, we add an extra check
to ensure the user is an admin. and we don't want to annoy the user
again if they already set the value. This is a bit of hack, but the
alternative would be to put in a more complex cache invalidation
step. Since this call only gets called in the uncommon situation where
the user is an admin and the only user in the instance, this shouldn't
cause too much load on the system.

Disabled password authentication for the users registered using
omniauth-ultraauth strategy

Signed-off-by: Utkarsh Gupta <guptautkarsh2102@gmail.com>

Udpated user_edit_profile_spec with time preferences

Minor update form fields

Francisco Javier López authored 5 years ago and James Lopez committed 5 years ago

Removed the conditions added to
Project.with_feature_available_for_user, and moved to the
IssuableFinder. Now, we ensure that, in the projects retrieved
in the Finder, the user has enough access for the feature.