Skip to content
Snippets Groups Projects
  1. Jan 07, 2016
  2. Dec 23, 2015
  3. Dec 22, 2015
  4. Dec 18, 2015
  5. Dec 17, 2015
  6. Dec 15, 2015
  7. Dec 14, 2015
  8. Dec 13, 2015
  9. Dec 11, 2015
  10. Dec 10, 2015
  11. Dec 09, 2015
  12. Dec 08, 2015
  13. Dec 07, 2015
  14. Dec 05, 2015
    • Robert Speicher's avatar
      Bump gitlab_emoji to ~> 0.2.0 · 6ee43ada
      Robert Speicher authored
      6ee43ada
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      d800a949
  15. Dec 04, 2015
  16. Dec 03, 2015
  17. Dec 02, 2015
  18. Nov 30, 2015
  19. Nov 27, 2015
  20. Nov 26, 2015
  21. Nov 25, 2015
  22. Nov 24, 2015
  23. Nov 23, 2015
  24. Nov 19, 2015
  25. Nov 16, 2015
Loading