Heinrich Lee Yu authored 5 years ago and Mayra Cabrera committed 5 years ago

Standardize punctuation and format

Mark Chao authored 5 years ago and James Lopez committed 5 years ago

Generalize wiki page counter for other page types to extend to.

🙈 jacopo beschi 🙉 authored 5 years ago and Mayra Cabrera committed 5 years ago

Extends the quick actions "commands applied" banner to show
the quick action preview text, but with everything in past tense.

Fix 'commands applied' messages not being shown when issue is promoted to epic
using slash commands.

Sets `updated_at` so that the transformed note is returned together with
the new reply

This reverts commit a82a5957, reversing
changes made to e7df959b.

Partially addresses #47424.

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070

Deprecate "chat commands" in favor of "slash commands"

We looked for things like:

 - `slash commmand`
 - `slash_command`
 - `slash-command`
 - `SlashCommand`

add /award slash command; Allow posting of just an emoji in comment

- Also remove unnecessary param

Signed-off-by: Rémy Coutable <remy@rymai.me>

Other improvements:
- Ensure slash commands autocomplete doesn't break when noteable_type is not given
- Slash commands: improve autocomplete behavior and /due command
- We don't display slash commands for note edit forms.
- Add tests for reply by email with slash commands
- Be sure to execute slash commands after the note creation in Notes::CreateService

Signed-off-by: Rémy Coutable <remy@rymai.me>

Check for update_issuable permission in Notes::SlashCommandsService

Signed-off-by: Rémy Coutable <remy@rymai.me>

Some important things to note:

- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
  params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
  the right place for advanced logic that has nothing to do with what
  models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
  only
- the `/merge` command is not handled yet

Other improvements:

- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService

Signed-off-by: Rémy Coutable <remy@rymai.me>

* There where path where +1 was stored as +1 not as thumbsup
  that was causing problems such as showing thumbsup icon 2 time.
  I fixed this to always normalize and store +1 as tumbsup

This reverts commit 3e991230.

# Conflicts:
#	app/models/project.rb