Skip to content
Snippets Groups Projects
  1. Jan 24, 2018
  2. Jan 21, 2018
  3. Jan 02, 2018
  4. Dec 30, 2017
    • Mario de la Ossa's avatar
      User#projects_limit remove DB default and added NOT NULL constraint · 75cf5f5b
      Mario de la Ossa authored
      This change is required because otherwise if a user is created with a
      value for `projects_limit` that matches the DB default, it gets
      overwritten by `current_application_settings.default_projects_limit`. By
      removing the default we once again can allow a user to be created with a
      limit of 10 projects without the risk that it'll change to 10000
      Unverified
      75cf5f5b
  5. Dec 22, 2017
  6. Dec 19, 2017
  7. Dec 08, 2017
  8. Dec 07, 2017
  9. Nov 23, 2017
  10. Nov 16, 2017
    • Yorick Peterse's avatar
      Cache the number of user SSH keys · 3e561736
      Yorick Peterse authored
      By caching the number of personal SSH keys we reduce the number of
      queries necessary on pages such as ProjectsController#show (which can
      end up querying this data multiple times).
      
      The cache is refreshed/flushed whenever an SSH key is added, removed, or
      when a user is removed.
      Verified
      3e561736
  11. Nov 14, 2017
  12. Nov 09, 2017
  13. Nov 07, 2017
  14. Nov 06, 2017
  15. Nov 03, 2017
  16. Nov 02, 2017
  17. Oct 07, 2017
  18. Oct 06, 2017
  19. Oct 05, 2017
  20. Sep 28, 2017
  21. Sep 24, 2017
  22. Sep 23, 2017
  23. Sep 11, 2017
  24. Sep 08, 2017
    • Rubén Dávila's avatar
      Revert "Merge branch... · 52a2423e
      Rubén Dávila authored
      Revert "Merge branch '35012-navigation-add-option-to-change-navigation-color-palette' into 'master'"
      
      This reverts merge request !13619
      52a2423e
  25. Sep 07, 2017
    • Yorick Peterse's avatar
      Rework how recent push events are retrieved · 83355336
      Yorick Peterse authored
      Whenever you push to a branch GitLab will show a button to create a
      merge request (should one not exist already). The underlying code to
      display this data was quite inefficient. For example, it involved
      multiple slow queries just to figure out what the most recent push event
      was.
      
      This commit changes the way this data is retrieved so it's much faster.
      This is achieved by caching the ID of the last push event on every push,
      which is then retrieved when loading certain pages. Database queries are
      only executed if necessary and the cached data is removed automatically
      once a merge request has been created, or 2 hours after being stored.
      
      A trade-off of this approach is that we _only_ track the last event.
      Previously if you were to push to branch A and B then create a merge
      request for branch B we'd still show the widget for branch A. As of this
      commit this is no longer the case, instead we will only show the widget
      for the branch you pushed to most recently. Once a merge request exists
      the widget is no longer displayed. Alternative solutions are either too
      complex and/or too slow, hence the decision was made to settle for this
      trade-off.
      
      Performance Impact
      ------------------
      
      In the best case scenario (= a user didn't push anything for more than 2
      hours) we perform a single Redis GET per page. Should there be cached
      data we will run a single (and lightweight) SQL query to get the
      event data from the database. If a merge request already exists we will
      run an additional DEL to remove the cache key.
      
      The difference in response timings can vary a bit per project. On
      GitLab.com the 99th percentile of time spent in User#recent_push hovers
      between 100 milliseconds and 1 second, while the mean hovers around 50
      milliseconds. With the changes in this MR the expected time spent in
      User#recent_push is expected to be reduced down to just a few
      milliseconds.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
      Unverified
      83355336
    • Annabel Dunstone Gray's avatar
      Use indigo as default theme · 99dcf870
      Annabel Dunstone Gray authored
      99dcf870
    • Tiago Botelho's avatar
      Removes default scope from sortable · cfd475a4
      Tiago Botelho authored
      cfd475a4
  26. Sep 06, 2017
  27. Sep 05, 2017
Loading