Closes #23460

For each event with `Event#target_type` of "Note",
we had a query to load the associated instance `noteable`.

For example, if `Note` was related to an issue, we'd load each `Issue`
with its own query (N+1 problem).

Closes #43150.

- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/

Closes #28857

Previously, this would issue a query for each unique `diff_refs_or_sha`
passed. This was because we didn't want to load other MR diffs into memory, as
they had some very large columns.

Now they are actually very small, and it's more efficient to just load them all
at once and do the finding in Ruby.

Douwe Maan authored 6 years ago and Mark Fletcher committed 6 years ago

Server Side Request Forgery in Services and Web Hooks

See merge request gitlab/gitlabhq!2337

This is a first step to decouple pipeline from YAML processing. It
reduces the coupling by removing some methods that introduce coupling
and by moving logic into separate chain element that is being used to
populate pipelines with stages and builds.

This appears to reduce the number of queries in pipeline creation of
gitlab-ce's .gitlab-ci.yml by 92

This also means we now need to mock this ci yaml file properly in the
test because otherwise the yaml_errors stay on the object and make all
the pipelines failed.

and fixes the project description not being imported

We can extend this later, but for now we don't have the use case.

The specs are based on a schema version that doesn't know about
`internal_ids` table. However, the actual code being execute relies on
it.