Previously, the `showStagedIcon` property was doing the opposite
of what its name suggested. It was rendering the staged icon when
`showStagedIcon` was `false` and rendering the regular icon when
it was `true`.

Remove token field from runners edit form

Closes #35060

See merge request gitlab-org/gitlab-ce!32231

Payton Burdette authored 5 years ago and Filipa Lacerda committed 5 years ago

Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry

Change the way totalNotes is calculated

See merge request gitlab-org/gitlab-ce!32191

Fix moving issues API failing when text includes commit URLs

Closes #66666

See merge request gitlab-org/gitlab-ce!32317

When a issue is moved from one project to another, all associated
Markdown text is rewritten in the context of the new project. If the
note contained a link to a commit URL, `CommitRewriter#rewrite` would
fail because `Commit#link_reference_pattern` would match `nil` `commit`
values in the HTML generated from the Markdown. These `nil` values were
passed along to `Project#commits_by` because `Commit#reference_valid?`
was always returning `true`.

To prevent this issue from happening, we tighten up the check for
`Commit#reference_valid?` to look for valid SHA values.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666

Adjusts snowplow to use cookies for sessions

Closes telemetry#77

See merge request gitlab-org/gitlab-ce!32236

Jeremy Jackson authored 5 years ago and Jan Provaznik committed 5 years ago

This also restructures how and where the configuration for
Snowplow lives.

Rename all filenames and occurrences to License Compliance

See merge request gitlab-org/gitlab-ce!32148

Achilleas Pipinellis authored 5 years ago and Evan Read committed 5 years ago

- New redirect doc/user/application_security/license_compliance/index.md
- Renaming of images.
- Some links that were pointing to the old location are fixed.

Remove a section for a now fixed bug

See merge request gitlab-org/gitlab-ce!32319

Edit Feature Flags topic

See merge request gitlab-org/gitlab-ce!31956

Those guidelines where based on
https://gitlab.com/gitlab-org/gitlab-docs/issues/311 which seems
to be fixed.

Fix markdown in various docs (part 1)

See merge request gitlab-org/gitlab-ce!32267

Marcel Amirault authored 5 years ago and Achilleas Pipinellis committed 5 years ago

Clean up issues that may cause the docs-lint
test to fail, such as trailing whitespace, no
EOF newline, blockquotes, etc

Fixes Introduced in text for our renderer

See merge request gitlab-org/gitlab-ce!32308

Note CI token exception to JWT requests in rate limit docs

See merge request gitlab-org/gitlab-ce!32168

Add Issue and Merge Request titles to Todo items

Closes #63488

See merge request gitlab-org/gitlab-ce!30435

totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded

issuable.discussions makes multiple requests, so
too expensive for this

This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast

CE Backport of EE changes

See merge request gitlab-org/gitlab-ce!32203

Remove eks from adding an existing cluster section

See merge request gitlab-org/gitlab-ce!32125

Ss/add board name to page title

See merge request gitlab-org/gitlab-ce!32074

Resolving minor formatting issues in gitlab-basics

Closes #65307

See merge request gitlab-org/gitlab-ce!32194

Rename dev, org, com helper

See merge request gitlab-org/gitlab-ce!32115

Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.

Update group permissions table documentation

See merge request gitlab-org/gitlab-ce!32020

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66091

Closes #66091

See merge request gitlab-org/gitlab-ce!32188

Russell Dickenson authored 5 years ago and Evan Read committed 5 years ago

Changed reference to Mattermost versions, so that it's clear which
menu navigation path applies.

Add docs for db_load_balancing metrics

See merge request gitlab-org/gitlab-ce!32044

Add QA specs for using IP rate limits

See merge request gitlab-org/gitlab-ce!32177

Document setting admin credentials in QA tests

See merge request gitlab-org/gitlab-ce!32271

CE backport for gitlab-org/gitlab-ee!15433 (Expose DesignType#notes_count in GraphQL)

See merge request gitlab-org/gitlab-ce!32037

Luke Duncalfe authored 5 years ago and Mayra Cabrera committed 5 years ago

Notes call `#after_note_created` and `#after_note_destroyed` on their
noteable in callbacks, so the noteable can perform tasks particular to
them, like cache expiry.

This is in preparation of the EE-specific class
`DesignManagement::Design` clearing its `user_notes_count` cache when
its note are created or destroyed.

Refactoring Rspec behaviour testing of a counter caching service into a
shared example.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13353