Skip to content
Snippets Groups Projects
  1. Mar 26, 2018
  2. Mar 07, 2018
  3. Mar 03, 2018
  4. Feb 22, 2018
  5. Feb 09, 2018
    • Douwe Maan's avatar
      Merge branch... · 5e9e5692
      Douwe Maan authored
      Merge branch 'security-10-4-25223-snippets-finder-doesnt-obey-feature-visibility' into 'security-10-4'
      
      [Port for security-10-4]: Makes SnippetFinder ensure feature visibility
      5e9e5692
  6. Feb 01, 2018
  7. Jan 05, 2018
  8. Jan 04, 2018
  9. Dec 12, 2017
  10. Dec 07, 2017
  11. Nov 23, 2017
  12. Nov 06, 2017
  13. Oct 23, 2017
  14. Oct 05, 2017
  15. Oct 03, 2017
  16. Oct 01, 2017
  17. Sep 29, 2017
  18. Sep 28, 2017
  19. Sep 18, 2017
  20. Sep 14, 2017
  21. Sep 07, 2017
  22. Sep 06, 2017
  23. Aug 31, 2017
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      5883ce95
  24. Aug 29, 2017
  25. Aug 21, 2017
Loading