Closes #23460

- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/

Closes #28857

Douwe Maan authored 6 years ago and Mark Fletcher committed 6 years ago

Server Side Request Forgery in Services and Web Hooks

See merge request gitlab/gitlabhq!2337

This appears to reduce the number of queries in pipeline creation of
gitlab-ce's .gitlab-ci.yml by 92

This also means we now need to mock this ci yaml file properly in the
test because otherwise the yaml_errors stay on the object and make all
the pipelines failed.

Attempted commits were failing due to the pre-recieve LfsIntegrity
check. This is skipped during tests making this failure silent.

This may lead to some being evicted and having to be cached again, but many MRs
get closed or updated in that time anyway.

Previously, we kept them all in the cache. We don't need the highlight results
for older diffs - if someone does view that (which is rare), we can do the
highlighting on the fly.

Updates Files::MultiService for the commits API which is in turn used by the
multi-file upload web UI

Ensures that files which should be in LFS are transformed into LFS pointers
Uses Lfs::Transformer which then links LfsObjectProjects on success

Prior to this change, this method was called add_namespace, which broke
the CRUD convention and made it harder to grep for what I was looking
for. Given the change was a find and replace kind of fix, this was
changed without opening an issue and on another feature branch.

If more dynamic calls are made to add_namespace, these could've been
missed which might lead to incorrect bahaviour. However, going through
the commit log it seems thats not the case.

If no parameters were specified for project features but Wikis were disabled,
we would get "NoMethodError: undefined method `[]' for nil:NilClass".

Closes #44019

When a project is not private, and the source branch not protected the
user can now select the option to allow maintainers to push to this
branch

Deleting a user would fail in the system hooks if the user had
`nil` column in `datetime` or `updated_at` fields.

Closes #43871

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

There are several quick actions now that don't need this access - /todo and
/unsubscribe for instance - but when these were first added, there
weren't. Quick actions are now responsible for checking their own permissions.

Closes gitaly#1046

Adam Pahlevi authored 8 years ago and Oswaldo Ferreir committed 7 years ago

change to symbol

add complete changelog

add test for /wip

unwip as sym

test for work in progress separate from issuable

This reverts commit 54a575f1, reversing
changes made to c63af942.

EE: Trace as artifacts (FileStorage and ObjectStorage)

Closes #4171

See merge request gitlab-org/gitlab-ee!4258

Move uploads to object storage

Closes #4163

See merge request gitlab-org/gitlab-ee!3867

Object store for artifacts

Closes gitlab-ce#29203

See merge request !1762

Signed-off-by: Rémy Coutable <remy@rymai.me>