Skip to content
Snippets Groups Projects
  1. Aug 01, 2016
  2. Jul 29, 2016
    • Timothy Andrew's avatar
      Implement review comments from @dbalexandre. · 7b2ad2d5
      Timothy Andrew authored
      1. Remove `master_or_greater?` and `developer_or_greater?` in favor of
         `max_member_access`, which is a lot nicer.
      
      2. Remove a number of instances of `include Gitlab::Database::MigrationHelpers`
         in migrations that don't need this module. Also remove comments where
         not necessary.
      
      3. Remove duplicate entry in CHANGELOG.
      
      4. Move `ProtectedBranchAccessSelect` from Coffeescript to ES6.
      
      5. Split the `set_access_levels!` method in two - one each for `merge` and
         `push` access levels.
      7b2ad2d5
    • Timothy Andrew's avatar
      Admins count as masters too. · cc1cebdc
      Timothy Andrew authored
      1. In the context of protected branches.
      
      2. Test this behaviour.
      cc1cebdc
  3. Jul 27, 2016
  4. Jul 26, 2016
  5. Jul 22, 2016
  6. Jul 01, 2016
  7. Jun 29, 2016
  8. Jun 16, 2016
  9. Jun 14, 2016
  10. Jun 13, 2016
  11. Mar 11, 2016
  12. Feb 18, 2016
  13. Oct 15, 2015
    • Yorick Peterse's avatar
      Improve ProjectTeam#max_member_access performance · 3025b711
      Yorick Peterse authored
      By comparing objects in Ruby we can greatly improve the performance of
      this method. In the worst case (should no data be eager loaded) this
      will run the same amount of queries as before, in the best case (when
      data _is_ eager loadeD) it requires no queries at all.
      
      The added benchmark used to produce around 273 iterations per second.
      With this commit this has been increased to almost 40 000 iterations per
      second: a speedup of roughly 145 times.
      
      Combined with eager loading Note associations this results in about 30
      queries less when viewing a single issue, this in turn cuts down the
      loading time by 30-40%.
      3025b711
  14. Oct 02, 2015
  15. Apr 14, 2015
  16. Mar 15, 2015
  17. Jan 01, 2015
  18. Oct 09, 2014
  19. Oct 03, 2014
  20. Sep 15, 2014
  21. Sep 14, 2014
  22. Jun 20, 2014
  23. Jun 04, 2014
  24. Jan 19, 2014
  25. Dec 25, 2013
  26. Dec 17, 2013
  27. Dec 14, 2013
  28. Aug 27, 2013
  29. Jun 26, 2013
  30. Jun 22, 2013
Loading