Skip to content
Snippets Groups Projects
  1. Mar 10, 2020
  2. Jan 25, 2020
  3. Jan 24, 2020
  4. Jan 23, 2020
  5. Oct 03, 2019
  6. Sep 20, 2019
  7. Sep 13, 2019
  8. Sep 04, 2019
  9. Jul 10, 2019
  10. Jan 16, 2019
  11. Jan 07, 2019
  12. Nov 17, 2018
    • gfyoung's avatar
      Enable even more frozen string for lib/gitlab · 7ec8af50
      gfyoung authored
      Enables frozen string for the following:
      
      * lib/gitlab/hook_data/**/*.rb
      * lib/gitlab/i18n/**/*.rb
      * lib/gitlab/import/**/*.rb
      * lib/gitlab/import_export/**/*.rb
      * lib/gitlab/kubernetes/**/*.rb
      * lib/gitlab/legacy_github_import/**/*.rb
      * lib/gitlab/manifest_import/**/*.rb
      * lib/gitlab/metrics/**/*.rb
      * lib/gitlab/middleware/**/*.rb
      
      Partially addresses gitlab-org/gitlab-ce#47424.
      7ec8af50
  13. Jul 07, 2018
  14. Jul 02, 2018
  15. Mar 02, 2018
  16. Feb 07, 2018
    • Lin Jen-Shin's avatar
      Put controller in its separate file · 5309d445
      Lin Jen-Shin authored
      5309d445
    • Lin Jen-Shin's avatar
      Use a controller to hold request values · bbfce29b
      Lin Jen-Shin authored
      So that we don't need to hold env after the request.
      This makes it much harder to test, especially Rails session is
      acting weirdly, so we need `dig('flash', 'flashes', 'alert')`
      to dig the actual flash value.
      bbfce29b
    • Lin Jen-Shin's avatar
      Try not to hold env and release the controller · d4d564c8
      Lin Jen-Shin authored
      after the request. This way, we could release the
      project referred from the controller, which potentially
      referred a repository which potentially allocated a lot of
      memories.
      
      Before this change, we could hold the last request data
      and cannot release the memory. After this change, the
      largest request data should be able to be collected from GC.
      
      This might not impact the instances having heavy load,
      as the last request should be changing all the time,
      and GC won't kick in for each request anyway.
      
      However it could still potentially allow us to free more
      memories for each GC runs, because now we could free one
      more request anyway.
      d4d564c8
  17. Nov 21, 2017
  18. Nov 20, 2017
    • Stan Hu's avatar
      Optimize read-only middleware so that it does not consume as much CPU · 3c52e2f0
      Stan Hu authored
      In !15082, we changed the behavior of the middleware to call
      `Rails.application.routes.recognize_path` whenever a new route arrived.
      However, this can be a CPU-intensive task because Rails needs to allocate
      memory and compile 850+ different regular expressions, which are complicated
      in GitLab.
      
      As a short-term fix, we can do a lightweight string match before
      we do the heavier comparison.
      
      Closes #40185, gitlab-com/infrastructure#3240
      3c52e2f0
  19. Nov 07, 2017
  20. Nov 02, 2017
  21. Oct 06, 2017
    • Toon Claes's avatar
      Create idea of read-only database · d1366971
      Toon Claes authored
      In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
      secondary node). But in GitLab CE it also might be useful to have the
      "read-only" idea around. So port it back to GitLab CE.
      
      Also having the principle of read-only in GitLab CE would hopefully
      lead to less errors introduced, doing write operations when there
      aren't allowed for read-only calls.
      
      Closes gitlab-org/gitlab-ce#37534.
      d1366971
Loading