- Apr 17, 2018
-
-
Phil Hughes authored
-
- Apr 16, 2018
-
-
Phil Hughes authored
Closes #45412
-
Andreas Brandl authored
This is useful for a transition period to migrate away from `NoninternalAtomicId`. In a situation where both the old and new code to generate a iid value is run at the same time (for example, during a deploy different nodes may serve both versions), this will lead to problems regarding the correct `last_value`. That is, what we track in `InternalId` may get out of sync with the maximum iid present for issues. With this change, we double-check that and correct the `last_value` with the maximum iid found in issues if necessary. This is subject to be removed with the 10.8 release and tracked over here: https://gitlab.com/gitlab-org/gitlab-ce/issues/45389 Closes #45269.
-
Simon Knox authored
-
- Apr 15, 2018
-
-
Luke Bennett authored
-
- Apr 13, 2018
-
-
Filipa Lacerda authored
[ci skip] Adds specs Adds specs
-
Filipa Lacerda authored
-
Filipa Lacerda authored
-
Luke Bennett authored
-
Luke Bennett authored
-
Jose Ivan Vargas Lopez authored
-
Luke Bennett authored
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Mike Greiling authored
-
Dmitriy Zaporozhets authored
If form does not have import sources checkboxes we should not reset import sources to empty. This fixes issue when import sources got reset after user modifies unrelated settings section like GitLab pages Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Phil Hughes authored
Closes #45326
-
Phil Hughes authored
-
Mike Greiling authored
-
- Apr 12, 2018
-
-
-
Phil Hughes authored
Closes #45314
-
Mike Greiling authored
-
Clement Ho authored
Revert "Merge branch '44870-remove-extra-space-around-comment-form-on-merge-requests' into 'master'" This reverts merge request !18120
-
Filipa Lacerda authored
-
Fabian Schneider authored
-
Ash McKenzie authored
-
- Apr 11, 2018
-
-
Michael Kozono authored
-
Takuya Noguchi authored
-
George Tsiolis authored
-
George Tsiolis authored
-
Lin Jen-Shin authored
-
Filipa Lacerda authored
-
Yorick Peterse authored
This refactors the Markdown pipeline so it supports the rendering of multiple documents that may belong to different projects. An example of where this happens is when displaying the event feed of a group. In this case we retrieve events for all projects in the group. Previously we would group events per project and render these chunks separately, but this would result in many SQL queries being executed. By extending the Markdown pipeline to support this out of the box we can drastically reduce the number of SQL queries. To achieve this we introduce a new object to the pipeline: Banzai::RenderContext. This object simply wraps two other objects: an optional Project instance, and an optional User instance. On its own this wouldn't be very helpful, but a RenderContext can also be used to associate HTML documents with specific Project instances. This work is done in Banzai::ObjectRenderer and allows us to reuse as many queries (and results) as possible.
-
Simon Knox authored
-
blackst0ne authored
In Rails 5.0 the `ActiveRecord::Inheritance::subclass_from_attributes` method was updated. Now it calls the `find_sti_class` method [1] which is overriden in the `Event` model and returns needed class (`Event` vs `PushEvent`). [1]: https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/inheritance.rb#L209 This commit fixes the errors like ``` 143) User#contributed_projects doesn't include IDs for unrelated projects Failure/Error: action = attrs.with_indifferent_access[inheritance_column].to_i NoMethodError: undefined method `with_indifferent_access' for nil:NilClass # ./app/models/event.rb:118:in `subclass_from_attributes' ``` which are raised on the `RAILS5=1 rspec ...` command.
-
Grzegorz Bizon authored
-
Bob Van Landuyt authored
When a user is not logged in, we want to show the `New Issue` link so he gets directed to the login flow first. When a project is archived, we never want to show the link.
-
Bob Van Landuyt authored
This prevents performing the requests, and disables all emoji reaction buttons
-
Bob Van Landuyt authored
This could only be possible for users that can create merge requests within a project. So they need to be a allowed to create a branch and create a merge request.
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
When a project is archived, don't show the button on the index page of merge requests
-