Signed-off-by: Rémy Coutable <remy@rymai.me>

[10.3] Fix XSS in issue label dropdown

See merge request gitlab/gitlabhq!2253

(cherry picked from commit 363ffabcebd7bb0d1a2d59ca1a75e4eadb4a4360)

ea1fb0ea Fix XSS in issue label dropdown

This adds various foreign key constraints, indexes, missing NOT NULL
constraints, and changes some column types from timestamp to
timestamptz.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/31811

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34435

Address flakey specs

This reverts commit 915e35a2, reversing
changes made to 9533786f.

Eric Eastwood authored 7 years ago and Winnie Hellmann committed 7 years ago

Tip from
https://robots.thoughtbot.com/write-reliable-asynchronous-integration-tests-with-capybara#directly-interacting-with-javascript

Tip from
https://robots.thoughtbot.com/write-reliable-asynchronous-integration-tests-with-capybara#directly-interacting-with-javascript

Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.

spec runs too fast so it doesn't match the first text. I think testing
that the loading indicator is hidden is enough