- Feb 14, 2018
-
-
Sean McGivern authored
Before, this would: 1. Not use the correct reference for non-JIRA external trackers. 2. Append 'Closes ' if an external tracker was enabled, but no issue matched the branch name.
-
- Feb 13, 2018
-
-
Stan Hu authored
When JIRA or Redmine were enabled and the branch name did not match the matching regular expression, the `issue_iid` would be `nil`, preventing users from creating merge requests. Closes #43193
-
- Feb 02, 2018
-
-
Andrew McCallum authored
-
- Jan 10, 2018
-
-
Sean McGivern authored
-
- Jan 09, 2018
-
-
Benedikt Huss authored
-
- Dec 22, 2017
-
-
blackst0ne authored
-
- Dec 05, 2017
-
-
Jan Provaznik authored
* new merge request can be created by sending an email to the specific email address (similar to creating issues by email) * for the first iteration, source branch must be specified in the mail subject, other merge request parameters can not be set yet * user should enable "Receive notifications about your own activity" in user settings to receive a notification about created merge request Part of #32878
-
- Nov 28, 2017
-
-
Sean McGivern authored
If a merge request was created with a branch name that also matched a tag name, we'd generate a comparison to or from the tag respectively, rather than the branch. Merging would still use the branch, of course. To avoid this, ensure that when we get the branch heads, we prepend the reference prefix for branches, which will ensure that we generate the correct comparison.
-
- Aug 02, 2017
-
-
Robert Speicher authored
-
- Jul 27, 2017
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Jul 24, 2017
-
-
Jarka Kadlecova authored
-
- Jun 14, 2017
-
-
Robert Speicher authored
-
- Apr 26, 2017
-
-
mhasbini authored
-
- Apr 06, 2017
-
-
Sean McGivern authored
Don’t show source project name when user does not have access See merge request !2081
-
- Mar 28, 2017
-
-
Robert Speicher authored
-
- Mar 17, 2017
-
-
Adam Niedzielski authored
Closes #28890
-
- Feb 21, 2017
-
-
Felipe Artur authored
-
- Nov 29, 2016
-
-
Douwe Maan authored
Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031
-
- Nov 01, 2016
-
-
Alex Sanford authored
If source branch or target branch doesn't exist in the project, display form validation errors. Previously, this caused a 500 error code.
-
- Oct 11, 2016
-
-
Artem Sidorenko authored
-
- Sep 01, 2016
-
-
Luke Howell authored
- Added an extra new line to the prepend of the Close message Fixes #21710
-
- Aug 03, 2016
-
-
Paco Guzman authored
This object will manage Gitlab::Git::Compare instances
-
- May 06, 2016
-
-
Sean McGivern authored
-
Sean McGivern authored
If a branch starts with an issue's IID, followed by a hyphen, the description will be updated to say that is closes the issue. This also updates the title of the merge request to 'Resolves "$issue-title"', as long as: - There is more than one commit in the merge request (if there is only one commit, the commit's title will be used as before) - The issue's IID is valid for the project
-
Sean McGivern authored
-