Skip to content
Snippets Groups Projects
  1. Feb 21, 2020
  2. Dec 20, 2019
  3. Sep 25, 2019
  4. Sep 04, 2019
  5. Jan 31, 2019
    • Kamil Trzcińśki's avatar
      Extract GitLab Pages using RubyZip · 66744469
      Kamil Trzcińśki authored
      RubyZip allows us to perform strong validation of
      expanded paths where we do extract file.
      
      We introduce the following additional checks
      to extract routines:
      
      1. None of path components can be symlinked,
      2. We drop privileges support for directories,
      3. Symlink source needs to point within the target directory,
         like `public/`,
      4. The symlink source needs to exist ahead of time.
      Verified
      66744469
  6. Jan 22, 2019
    • Kamil Trzcińśki's avatar
      Extract GitLab Pages using RubyZip · 1a8100cf
      Kamil Trzcińśki authored
      RubyZip allows us to perform strong validation of
      expanded paths where we do extract file.
      
      We introduce the following additional checks
      to extract routines:
      
      1. None of path components can be symlinked,
      2. We drop privileges support for directories,
      3. Symlink source needs to point within the target directory,
         like `public/`,
      4. The symlink source needs to exist ahead of time.
      1a8100cf
  7. Jul 17, 2018
  8. Apr 27, 2018
  9. Apr 03, 2018
  10. Mar 30, 2018
  11. Mar 09, 2018
  12. Mar 06, 2018
  13. Feb 28, 2018
  14. Feb 05, 2018
    • Grzegorz Bizon's avatar
      Revert create job service because of load balancing · 5f57c7a5
      Grzegorz Bizon authored
      Currently we still need to run EnsureStageService within a transaction,
      because when it runs within in a transaction we are going to stick to
      the primary database when using database load balancing. Extracting this
      out of the transaction makes it possible to hit into problems with
      replication lag in pipeline commit status API, which can cause a lot of
      trouble.
      5f57c7a5
  15. Feb 02, 2018
  16. Jan 24, 2018
  17. Dec 03, 2017
  18. Sep 05, 2017
  19. Aug 31, 2017
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      5883ce95
  20. Aug 10, 2017
  21. Jul 31, 2017
  22. Jul 26, 2017
  23. Jul 25, 2017
  24. Jun 28, 2017
  25. Mar 31, 2017
  26. Mar 05, 2017
  27. Feb 23, 2017
  28. Feb 01, 2017
Loading