Skip to content
Snippets Groups Projects
  1. Mar 28, 2018
  2. Mar 07, 2018
    • Stan Hu's avatar
      Memoize Repository#empty? instead of double caching the value · 611929eb
      Stan Hu authored
      We saw that in a customer instance, `empty?` was cached to be `true` even
      though `has_visible_content?` and `exists?` were `true`. This double caching
      can run into edge cases because there's no guarantee that the inner values
      will properly expire the outer one, especially if there is Redis replication lag.
      Consider this scenario:
      
      1. `exists?` and `has_visible_content?` are false
      2. `empty?` is expired
      3. A subsequent call to `empty?` returns `true` because `exists?` is false even though `empty` is true
      4. `exists?` and `has_visible_content?` are then expired
      5. `exists?` and `has_visible_content?` are set to true
      6. `empty?` is still stuck in the wrong value as `true`
      
      Closes #43882
      611929eb
    • Alejandro Rodríguez's avatar
  3. Mar 06, 2018
  4. Mar 05, 2018
  5. Mar 01, 2018
  6. Feb 23, 2018
  7. Feb 17, 2018
  8. Feb 14, 2018
  9. Feb 07, 2018
  10. Feb 06, 2018
  11. Feb 02, 2018
  12. Feb 01, 2018
    • Zeger-Jan van de Weg's avatar
      Client changes for Tag,BranchNamesContainingCommit · 0a47d192
      Zeger-Jan van de Weg authored
      As part of gitlab-org/gitaly#884, this commit contains the client
      implementation for both TagNamesContaintingCommit and
      BranchNamesContainingCommit. The interface in the Repository model stays
      the same, but the implementation on the serverside, e.g. Gitaly, uses
      `for-each-ref`, as opposed to `branch` or `tag` which both aren't
      plumbing command. The result stays the same.
      
      On the serverside, we have the opportunity to limit the number of names
      to return. However, this is not supported on the front end yet. My
      proposal to use this ability: gitlab-org/gitlab-ce#42581. For now, this
      ability is not used as that would change more behaviours on a feature
      flag which might lead to unexpected changes on page refresh for example.
      Unverified
      0a47d192
  13. Jan 30, 2018
  14. Jan 25, 2018
  15. Jan 24, 2018
  16. Jan 22, 2018
  17. Jan 18, 2018
  18. Jan 16, 2018
  19. Jan 15, 2018
  20. Jan 12, 2018
  21. Jan 11, 2018
  22. Jan 10, 2018
  23. Jan 09, 2018
  24. Jan 05, 2018
Loading