Fix sharing notes data in localStorage with all MRs

See merge request gitlab-org/gitlab-ce!32699

(cherry picked from commit 6dd99d82)

4fb658d1 Fix sharing localStorage with all MRs

Bring method back that was mistakenly removed

See merge request gitlab-org/gitlab-ce!32667

(cherry picked from commit 0fad0ed8)

0a9cc6ab Bring method back that was mistakenly removed

Avoid checking dns rebind protection in validation

Closes #66723

See merge request gitlab-org/gitlab-ce!32577

(cherry picked from commit 4e9c531a)

8f07ba0d Avoid checking dns rebind protection in validation

Preload routes information in Routable

See merge request gitlab-org/gitlab-ce!32352

(cherry picked from commit 8326e84e)

53801b12 Preload routes information

Previously, the `showStagedIcon` property was doing the opposite
of what its name suggested. It was rendering the staged icon when
`showStagedIcon` was `false` and rendering the regular icon when
it was `true`.

Filipa Lacerda authored 5 years ago and Mayra Cabrera committed 5 years ago

Updates frontend code and specs to allow for the new
feature flag

Manoj M J authored 5 years ago and Mayra Cabrera committed 5 years ago

This change limits the number of emails
for new access requests notifications to
10 most recently active owners/maintainers

This is to accomodate prepended modules.

All avatars now visible in commit trailers.

This does not support upgrading from earlier versions

When deployable is nil, we gracefully take care of the case.

We should see the ratio drop down when enabling the Feature.

Recommendation by @andrewn

- Use "results" instead of "blobs", "wiki blobs", "snippet blobs"
- Use "comments" instead of "notes"
- Use correct pluralization
- Don't add "1 - 10 of" if there's only one page

This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.

In order to lookup a Project or Namespace by path, we prefer an exact
match (case-sensitive) but in absence of that, we'd also take a
case-insensitive match.

The case-insensitive matching with preference for the exact match is a
bit more involved in SQL as the exact lookup. Yet, the majority of cases
will be an exact match. The thinking here is that we can optimize the
lookup by performing an exact match first and only if there is no
result, we perform the case-insensitive lookup.

Data for GitLab.com:
* We have about 15M records in routes table
* About 2,500 routes exist where there's more than one record
  with the same `lower(path)`

It is possible for a user to craft requests that would always trigger
the 2-step search (e.g. we have a route for `/foo/bar`, the request is
always for `/FOO/bar`). In this case, the change at hand is not
beneficial as it would run an additional query.

However, based on the data, it is highly likely that the vast majority
of requests can be satisfied with an exact match only.

The context for this change is
https://gitlab.com/gitlab-org/gitlab-ce/issues/64590#note_208156463.

Jan Beckmann authored 5 years ago and Paul Slaughter committed 5 years ago

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/62055

Alexis Kalderimis authored 5 years ago and Thong Kuah committed 5 years ago

This allows the be_url matcher to be more specific. By default, it only
matches HTTP and HTTPS URIs.

Previously submitting a DELETE request to an issuable URL would be
enough to destroy it, but this should require human confirmation.  We
now require that the `destroy_confirm` parameter is set to a truthy
value before this can complete.

In addition, we log a Sentry error if a deletion arrived without
confirmation.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62387

João Cunha authored 5 years ago and Jan Provaznik committed 5 years ago

Extract duplicated code from two similar classes into a parent one.

This reverts commit 0eff75fa.

Fix missing .btn-success class on the following buttons:
* 'Create milestone' button
* Secondary button on profile tabs

`btn-create` was an old class which was was removed in !23232
and replaced with `btn-success`,
but these two seem to have been missed in the process.

Signed-off-by: Tao Wang <twang2218@gmail.com>
Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

Add E2E spec to test that issue closes with commit message

This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.

When a restricted visibility level of `private` is set in the instance,
creating a snippet with the `visibility` level would always fail.
This happened because:

1. `params[:visibility]` was a string (e.g. "public")
2. `CreateSnippetService` and `UpdateSnippetService` only looked
   at `params[:visibility_level]`, which was `nil`.

To fix this, we:

1. Make `CreateSnippetService` look at the newly-built
   `snippet.visibility_level`, since the right value is assigned by the
   `VisibilityLevel#visibility=` method.
2. Modify `UpdateSnippetService` to handle both `visibility_level` and
`visibility` parameters.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66050

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8186

It should not be a start to a new thread but rather
a reply to an existing thread

Changes the document event listener to listen to
mousedown instead of click

Igor Drozdov authored 5 years ago and Mayra Cabrera committed 5 years ago

- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count