Fix sharing notes data in localStorage with all MRs

See merge request gitlab-org/gitlab-ce!32699

(cherry picked from commit 6dd99d82)

4fb658d1 Fix sharing localStorage with all MRs

When deployable is nil, we gracefully take care of the case.

Igor Drozdov authored 5 years ago and Mayra Cabrera committed 5 years ago

- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count

Prefer the deployable user over the deployment user.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/66037.

Igor Drozdov authored 5 years ago and Paul Slaughter committed 5 years ago

- Edit commit messge body to fix "danger-review"

Samantha Ming authored 5 years ago and Paul Slaughter committed 5 years ago

Add merge warning on avatar in:
- open view assigness
- collapsed view assigness
- dropdown (search) view assigness

Add can_merge option to MR sidebar entity

Instead of `finished_at` attribute use `deployed_at` methods which also
takes into account the deployment status.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.

Brett Walker authored 5 years ago and Paul Slaughter committed 5 years ago

- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.

Igor Drozdov authored 5 years ago and Douwe Maan committed 5 years ago

Splits auto-refreshing of MR widget into 2 requests:

- the one which uses etag-caching and invalidates the fields on change
- the one without caching

The idea is to gradually move all the fields to etag-cached endpoint

As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593

mksionek authored 5 years ago and Mayra Cabrera committed 5 years ago

Add project path to sql query to build proper path

This commit changes how we eager-load projects, routes, and namespaces
required by the deploy keys endpoint, getting a 10x improvement in my
local testing.

The endpoint still doesn't scale in-general, but going from ~13 seconds
to dump a 63K result to generating the same thing in ~1.6 seconds seems
like a good improvement to me.

It's used only if merge_request_iid param is provided

Convert several occurrences of `map` + `flatten` to
`flat_map` where applicable.

Igor Drozdov authored 5 years ago and Nick Thomas committed 5 years ago

This is part of migration of Folder View to Vue

Change small things for better readability

Add specs for group level

Update entities

Update base classes

Add groups-centric changes

Update plan and review stage

Add summary classes

Add summary spec

Update specs files

Add to specs test cases for group

Add changelog entry

Add group serializer

Fix typo

Fix typo

Add fetching namespace in sql query

Update specs

Add rubocop fix

Add rubocop fix

Modify method to be in sync with code review

Add counting deploys from subgroup

To group summary stage

Add subgroups handling

In group stage summary

Add additional spec

Add additional specs

Add more precise inheritance

Add attr reader to group level

Fix rubocop offence

Fix problems with specs

Add cr remarks

Renaming median method and a lot of calls in specs

Move spec setup

Rename method in specs

Add code review remarks regarding module

Add proper module name

Winnie Hellmann authored 5 years ago and Jan Provaznik committed 5 years ago

(cherry picked from commit 1e8bdd01bff96122fe80c51fa8f024f18675b58b)

Do not show moved issue id for users that cannot read issue

We can now share project so that we don't have to load project twice.
Also, this extracts non-relevant logic out of Deployment.

Update DeploymentsController accordingly

Currently, we do not cap amount of tests returned to frontend,
thus in some extreme cases we can see a MBs of data stored in Redis.

This adds an upper limit of 100 tests per-suite.

We will continue showing the total counters correctly,
but we will limit amount of tests that will be presented.

This commits extracts /merge_requests/1.json?serializer=widget
Into a separate /merge_requests/1/widget.json endpoint
This will allow to use caching for this request

Refactor code to allow multiple issue boards management for projects
in CE

- Add test for N+1 queries
- Add destroyable lists scope to Board and List
- Preload lists for both project and group boards

The merge request widget has a section that includes which issues may be
closed or mentioned based on the merge request description. The problem
is that rendering and redacting Markdown can be expensive, especially
since the browser polls for the data every 10 seconds.

Since these links don't change much and are just nice to have, we only
load them on first page load. The frontend will use the existing data if
the data doesn't appear on subsequent requests.

This saves about 30% of the rendering time of this endpoint, which adds
up to significant savings considering that
`MergeRequestsController#show.json` is called over a million times a day
on GitLab.com.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63546

This reverts merge request !26853

With this commit, we add docs link for confidential
and locked issues to note compose and edit forms

- Add serializers and Grape::Entity
- Replace to_json
- Add specs

We have one auto merge strategy today - Merge When Pipeline
Succeeds.

In order to add more strategies for Merge Train feature,
we abstract the architecture to be more extensible.

Removed arguments

Fix spec

Mike Scott authored 5 years ago and Filipa Lacerda committed 5 years ago

* Add Pipeline IID to MR's
* Add Pipeline IID to commit box
* Add Pipeline IID to builds page
* Add Pipeline IID to job sidebar
* Add Pipeline IID to header on view pipeline pages
* Add changelog entry
* Update tests

Extracts combining the job_artifacts relation with the with_reports
scope for getting report artifacts into a method.

Exposes report download paths in build details.