Fix sharing notes data in localStorage with all MRs

See merge request gitlab-org/gitlab-ce!32699

(cherry picked from commit 6dd99d82)

4fb658d1 Fix sharing localStorage with all MRs

When deployable is nil, we gracefully take care of the case.

Igor Drozdov authored 5 years ago and Mayra Cabrera committed 5 years ago

- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count

Samantha Ming authored 5 years ago and Paul Slaughter committed 5 years ago

Add merge warning on avatar in:
- open view assigness
- collapsed view assigness
- dropdown (search) view assigness

Add can_merge option to MR sidebar entity

Instead of `finished_at` attribute use `deployed_at` methods which also
takes into account the deployment status.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.

As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593

mksionek authored 5 years ago and Mayra Cabrera committed 5 years ago

Add project path to sql query to build proper path

Also creates specs

Only allow Helm to be uninstalled if it's the only app

- Remove Tiller leftovers after reser command
- Fixes specs and offenses

Adds changelog file

Fix reset_command specs

It's used only if merge_request_iid param is provided

These are not required because MySQL is not
supported anymore

Igor Drozdov authored 5 years ago and Nick Thomas committed 5 years ago

This is part of migration of Folder View to Vue

Add specs for group level

Update entities

Update base classes

Add groups-centric changes

Update plan and review stage

Add summary classes

Add summary spec

Update specs files

Add to specs test cases for group

Add changelog entry

Add group serializer

Fix typo

Fix typo

Add fetching namespace in sql query

Update specs

Add rubocop fix

Add rubocop fix

Modify method to be in sync with code review

Add counting deploys from subgroup

To group summary stage

Add subgroups handling

In group stage summary

Add additional spec

Add additional specs

Add more precise inheritance

Add attr reader to group level

Fix rubocop offence

Fix problems with specs

Add cr remarks

Renaming median method and a lot of calls in specs

Move spec setup

Rename method in specs

Add code review remarks regarding module

Add proper module name

Do not show moved issue id for users that cannot read issue

Some of the specs were using namespace names instead of paths for
building URLS. This would fail since we now build a namespace with a
user's name instead of a user's username.

Otherwise, each EnvironmentStatus object instantiates its own project
when really they are the same. Improves query count performance

Currently, we do not cap amount of tests returned to frontend,
thus in some extreme cases we can see a MBs of data stored in Redis.

This adds an upper limit of 100 tests per-suite.

We will continue showing the total counters correctly,
but we will limit amount of tests that will be presented.

The merge request widget has a section that includes which issues may be
closed or mentioned based on the merge request description. The problem
is that rendering and redacting Markdown can be expensive, especially
since the browser polls for the data every 10 seconds.

Since these links don't change much and are just nice to have, we only
load them on first page load. The frontend will use the existing data if
the data doesn't appear on subsequent requests.

This saves about 30% of the rendering time of this endpoint, which adds
up to significant savings considering that
`MergeRequestsController#show.json` is called over a million times a day
on GitLab.com.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63546

James Fargher authored 5 years ago and Thong Kuah committed 5 years ago

We are deprecating this service in favor of instance wide clusters.
Therefore we removed some code that is not anymore needed for a
readonly cluster and also we added some flags to allow for this
deprecation. These flags are to be removed in the next release when
we finally completelly remove KubernetesService.

- Add serializers and Grape::Entity
- Replace to_json
- Add specs

We have one auto merge strategy today - Merge When Pipeline
Succeeds.

In order to add more strategies for Merge Train feature,
we abstract the architecture to be more extensible.

Removed arguments

Fix spec

Extracts combining the job_artifacts relation with the with_reports
scope for getting report artifacts into a method.

Exposes report download paths in build details.

Grzegorz Bizon authored 5 years ago and Filipa Lacerda committed 5 years ago

Fixes style lint errors

Grzegorz Bizon authored 5 years ago and Filipa Lacerda committed 5 years ago

This change makes it possible to avoid additional serialization of
entire pipeline when rendering a build details page. Instead we expose
more information from the build entity itself what is much cheaper than
serializing entire pipeline.

Additionally we do not need to serialize `latest?` flag, which involves
multiple Gitaly calls.

Refactor

- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs

Only prometheus can be uninstalled atm, the rest will be dealt with
later.

Presumption is that new application types will have uninstallation
implmemented at the same time.

Imre (Admin) authored 5 years ago and Andreas Brandl committed 5 years ago

Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE

This reverts merge request !26823

Imre (Admin) authored 5 years ago and Andreas Brandl committed 5 years ago

Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE