By adding [skip visual] to the commit message the
gitlab:ui:visual test can be skipped.

This is needed to avoid deadlock situations as exhibited in
https://gitlab.com/gitlab-org/gitlab-ui/issues/198

This reverts commit 34293b5a, reversing
changes made to fdcfae2a.

Conflicts:
	.gitlab-ci.yml

Signed-off-by: Rémy Coutable <remy@rymai.me>

Use self.integrity_uri over self.hexdigest_integrity_uri(digest), as the
latter always returned nil leading to improper cache invalidation.

We are alos enabling caching of `tmp/cache/assets/sprockets` again, to
get those performance gains.

Signed-off-by: Rémy Coutable <remy@rymai.me>

By changing the `review-build-cng` job to be a `single-script-job`, the
repository content wasn't there, including the `*_VERSION` files, thus
leading to missing variables for components in the triggered pipeline.

Signed-off-by: Rémy Coutable <remy@rymai.me>

This started with
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24339 where a
broken link was introduced, but the lint checker never caught it.

The docs-lint job does the following:

```yaml
  script:
    - mv doc/ /tmp/gitlab-docs/content/
    - cd /tmp/gitlab-docs
    # Build HTML from Markdown
    - bundle exec nanoc
    # Check the internal links
    - bundle exec nanoc check internal_links
```

It moves the `doc/` dir inside `content` where Nanoc is expecting the
markdown files to be. It then builds the site and finally checks for
the links. If the built website was deployed to production, that would
be under `docs.gitlab.com/doc`.

The interesting part here is that
`[the logs](/doc/administration/logs.md#productionlog)`
translates to `<a href="/doc/administration/logs.html#productionlog>`,
so, Nanoc correctly sees this as an existing file!

This MR changes the path of the docs content to be equal to
$DOCS_GITLAB_REPO_SUFFIX which is defined as an environment
variable and takes the value of the slug of each project:
'ce', 'ee', 'omnibus', 'runner'.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Rémy Coutable authored 6 years ago and Shinya Maeda committed 6 years ago

This reverts merge request
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24388

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Optionally compiling assets when needed for qa jobs proved
unworkable so instead we fall back on compiling them for
all qa jobs.

In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20654 this job
was marked as allowing failures, but this allows developers to ignore
the results that Danger produces. Since it's not clear why the job was
allowed to fail, and since it's somewhat counter productive, we no
longer allow it to fail.

This check never worked once the global navigation changes were rolled
out in https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/362. The
global nav will ALWAYS include /ce and /ee links, and the CE and EE
repos will never include documentation for both.  gitlab-docs now
expects the documentation to be in the following directories:

* /tmp/gitlab-docs/ce (CE)
* /tmp/gitlab-docs/ee (EE)
* /tmp/gitlab-docs/omnibus (Omnibus)

The problem is that the CE and EE repos will only include one of the
first two.

Let's disable this check until
https://gitlab.com/gitlab-com/gitlab-docs/issues/305 is resolved.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55038

Signed-off-by: Rémy Coutable <remy@rymai.me>

Apparently disabling it by checking for a variable doesn't actually
disable it.

[ci skip]