Skip to content
Snippets Groups Projects
  1. Feb 28, 2020
  2. Sep 18, 2019
  3. Sep 04, 2019
  4. Sep 03, 2019
  5. Aug 01, 2019
  6. Mar 18, 2019
  7. Feb 07, 2019
  8. Nov 01, 2018
  9. Aug 01, 2018
  10. Jul 16, 2018
  11. Apr 10, 2018
  12. Apr 07, 2018
  13. Feb 02, 2018
  14. Oct 10, 2017
  15. Oct 08, 2017
  16. Aug 31, 2017
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      5883ce95
  17. Aug 07, 2017
  18. May 29, 2017
  19. Mar 31, 2017
  20. Mar 30, 2017
  21. Mar 29, 2017
  22. Mar 23, 2017
  23. Mar 22, 2017
  24. Mar 21, 2017
  25. Feb 23, 2017
  26. Feb 22, 2017
  27. Feb 03, 2017
Loading