Skip to content
Snippets Groups Projects
  1. Sep 13, 2019
  2. Sep 11, 2019
  3. Sep 09, 2019
    • Enrique Alcántara's avatar
      Create new feature flagged UI for cloud providers · 90e3a491
      Enrique Alcántara authored
      - Create HAML UI select a cloud provider to create a cluster.
      - Add query param to :new cluster view to display a specific cluster
      provider form depending on the value of the provider query param.
      - Update unit tests and e2e tests to reflect these changes
      90e3a491
  4. Jun 17, 2019
  5. Jun 07, 2019
  6. May 03, 2019
  7. Apr 16, 2019
  8. Mar 29, 2019
  9. Feb 26, 2019
  10. Feb 25, 2019
  11. Feb 04, 2019
    • Mayra Cabrera's avatar
      Addresses backend/db review comments · 087af654
      Mayra Cabrera authored
      - Fixes multiple typos on AutoDevops script
      - Add an alias to Clusters::Cluster#domain as base_domain, so it's more
      descriptive
      - Removes unnecessary memoization on qa specs
      - Changes migration to a post migration to deal better with traffic on
      big instances (like gitlab.com)
      087af654
    • Mayra Cabrera's avatar
      Moves domain setting to Cluster setting · 8ff73614
      Mayra Cabrera authored
      Changes domain field to be on the Cluster page show, removing it from
      Auto DevOps setting. Also injects the new environment variable
      KUBE_INGRESS_BASE_DOMAIN into kubernetes#predefined_variables.
      
      Migration to move the information from ProjectAutoDevops#domain
      to Clusters::Cluster#domain. As well as necessary modifications to qa
      selectors
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52363
      8ff73614
  12. Dec 16, 2018
    • Thong Kuah's avatar
      Use finder to decide to show note to user · f82c9dbe
      Thong Kuah authored
      Given the note is about how to interpret ancestor clusters, use the
      finder which actually knows if there are any ancestor clusters to find
      out if the note should be shown, rather than passing the same info via a
      view to a helper
      
      Added note about Kaminari.paginate_array
      
      Link to followup issue too
      f82c9dbe
    • Thong Kuah's avatar
      Show clusters of ancestors in cluster list page · 7e4f76ea
      Thong Kuah authored
      Show both the cluster(s) of the clusterable, and the cluster(s) of
      ancestor groups.
      7e4f76ea
  13. Dec 10, 2018
  14. Nov 08, 2018
  15. Nov 01, 2018
    • Thong Kuah's avatar
      Resolve controller sharing concern · 1a1fdf8e
      Thong Kuah authored
      Use ClustersController as base while having Projects::ClustersController
      to inform what `clusterable` is. Thanks @ayufan for the great suggestion
      !
      
      - View changes to work with new approach
      
      - Fix javascript for new approach
      
      - Fix feature specs for new approach
      
      - Fix QA
      1a1fdf8e
    • Thong Kuah's avatar
      Move view and path concerns to presenters · 1163b235
      Thong Kuah authored
      - Move show path for cluster to ClusterPresenter
      
      - Create ClusterablePresenter to encapsulate logic. Consolidates
      scattered methods from BaseController and ClustersHelper into an object.
      1163b235
    • Thong Kuah's avatar
      Abstract out project out of ClustersController · 88800abc
      Thong Kuah authored
      To the extent possible swap out `project` with `clusterable`
      
      - Abstract paths for showing cluster or clusters. This will allow us to
      swap in alternative paths for group level cluster
      
      - Push :project_id and :namespace_id params from the URL to the POST
      body.
      
      - Create a nice helper for to generate links for the destroy
      action
      
      For some reason, spec :project_id and :namespace_id param are not going
      through `to_param` for a JSON format. Manually call `to_param` to fix
      specs.
      
      - Move :layout to BaseController
      88800abc
    • Thong Kuah's avatar
      Convert clusters to use a top-level controller · 5b3c096c
      Thong Kuah authored
      In preparation so that we can create both cluster attached to project
      and cluster attached to group.
      
      - Move ClustersController to top level
      
      - Move Clusters::ApplicationsController to top-level too
      
      - Creates a Clusters::BaseController to share common functions
      
      - Do not rely on @Project ivar. Anything could set the ivar.
      
      - Fix Vue page components due to new data-page value
      
      Because of the controller change we have gone from
      `projects:clusters:new` to `clusters:new`, so we need to update the file
      location of the page components. There is somewhere a function that will
      convert data-page to a file location.
      
      On that note, projects/clusters/gcp/new/, translate to
      Projects::Clusters::Gcp#new doesn't exist so replace that with
      clusters/create_gcp/ and clusters/create_user/
      5b3c096c
  16. Oct 14, 2018
    • Thong Kuah's avatar
      Pass in project as kwarg for CreateService · 19e1024b
      Thong Kuah authored
      This enables us to have other options in the future such as passing in
      `group:`.
      
      Also, remove project arg from UpdateService, as un-used.
      
      This will help group cluster controller to re-use this services.
      19e1024b
  17. Sep 26, 2018
    • gfyoung's avatar
      Enable even more frozen string in app/controllers · 12ee2753
      gfyoung authored
      Enables frozen string for some vestigial files as
      well as the following:
      
      * app/controllers/projects/**/*.rb
      * app/controllers/sherlock/**/*.rb
      * app/controllers/snippets/**/*.rb
      * app/controllers/users/**/*.rb
      
      Partially addresses #47424.
      12ee2753
  18. Sep 14, 2018
  19. Sep 06, 2018
  20. Jul 09, 2018
  21. Jun 19, 2018
  22. Jun 06, 2018
  23. May 26, 2018
  24. May 25, 2018
  25. May 24, 2018
  26. Feb 22, 2018
  27. Feb 20, 2018
  28. Feb 06, 2018
  29. Dec 16, 2017
Loading