- Sep 13, 2019
-
-
GitLab Bot authored
-
- May 15, 2019
-
-
James Edwards-Jones authored
Since this needs to be called on every find_routable!(Project, ... we can instead move it to a RoutableActions check.
-
James Edwards-Jones authored
-
- Nov 01, 2018
-
-
Thong Kuah authored
When we unhooked ClustersController from Project::ApplicationsController, we missed an EE override to handle_not_found_or_authorized. Rather than carry on with override RoutingActions, make a specific proc for Project that we override in EE instead. Use that proc in both Clusters::BaseController and Project::ApplicationsController.
-
- Sep 19, 2018
-
-
gfyoung authored
Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424.
-
- Feb 22, 2018
-
-
Bob Van Landuyt authored
-
- Jan 11, 2018
-
-
- May 19, 2017
-
-
Michael Kozono authored
In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change: When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
-
- May 18, 2017
-
-
Michael Kozono authored
Don’t replace a substring of the path if it is part of the top level route. E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`. Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests.
-
Michael Kozono authored
The host should not be modified, nor is it needed for the redirect.
-
- May 11, 2017
-
-
Michael Kozono authored
-
- May 05, 2017
-
-
Michael Kozono authored
-
Michael Kozono authored
Note: This changes the behavior of user lookups (see the spec change) so it acts the same way as groups and projects. Unauthenticated clients attempting to access a user page will be redirected to login whether the user exists and is publicly restricted, or does not exist at all.
-
Michael Kozono authored
-
Michael Kozono authored
-