Skip to content
Snippets Groups Projects
  1. Sep 13, 2019
  2. May 15, 2019
  3. Nov 01, 2018
    • Thong Kuah's avatar
      Restore 403 functionality for external auth (EE) · 28dabc67
      Thong Kuah authored
      When we unhooked ClustersController from
      Project::ApplicationsController, we missed an EE override to
      handle_not_found_or_authorized.
      
      Rather than carry on with override RoutingActions, make a specific proc
      for Project that we override in EE instead. Use that proc in both
      Clusters::BaseController and Project::ApplicationsController.
      28dabc67
  4. Sep 19, 2018
    • gfyoung's avatar
      Enable frozen string in app/controllers/**/*.rb · 73322a0e
      gfyoung authored
      Enables frozen string for the following:
      
      * app/controllers/*.rb
      * app/controllers/admin/**/*.rb
      * app/controllers/boards/**/*.rb
      * app/controllers/ci/**/*.rb
      * app/controllers/concerns/**/*.rb
      
      Partially addresses #47424.
      73322a0e
  5. Feb 22, 2018
  6. Jan 11, 2018
  7. May 19, 2017
    • Michael Kozono's avatar
      Refactor to more robust implementation · 49697bc8
      Michael Kozono authored
      In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change:
      
      When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
      49697bc8
  8. May 18, 2017
    • Michael Kozono's avatar
      Fix ensure_canonical_path for top level routes · f9785dce
      Michael Kozono authored
      Don’t replace a substring of the path if it is part of the top level route.
      
      E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`.
      
      Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests.
      f9785dce
    • Michael Kozono's avatar
      Fix #32506 · 52aba709
      Michael Kozono authored
      The host should not be modified, nor is it needed for the redirect.
      52aba709
  9. May 11, 2017
  10. May 05, 2017
Loading